Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inclusion bot #552

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update inclusion bot #552

merged 2 commits into from
Oct 15, 2024

Conversation

mgwalker
Copy link
Member

Adds "kowtow" to the bot.


Checklist:

  • Code has been formatted with prettier
  • The OAuth wiki
    page has been updated if Charlie needs any new OAuth events or scopes
  • The Environment Variables
    wiki page has been updated if new environment variables were introduced
    or existing ones changed
  • The dev wiki has been updated, e.g.:
    • local development processes have changed
    • major development workflows have changed
    • internal utilities or APIs have changed
    • testing or deployment processes have changed
  • If appropriate, the NIST 800-218 documentation has been updated

@mgwalker mgwalker requested a review from beechnut September 25, 2024 15:20
@mgwalker mgwalker requested a review from a team as a code owner September 25, 2024 15:20
| Goddamn, goddam, goddamnit, goddammit | awful, terrible, wretched | This term can be offensive or triggering to some religious traditions because it implies a deity cursing or reproaching people. We want to show respect towards all religious traditions. |
| jesus fucking, fucking christ | Wow, oh no, oh my | We want to show respect towards all religious traditions. |
| mumbo jumbo | jargon, confusing language | The term "mumbo jumbo" was used to stereotype African languages and cultures that didn't make sense to European colonizers. <br><br> See [Here are some commonly used terms that actually have racist origins](https://abcnews.go.com/Politics/commonly-terms-racist-origins/story?id=71840410) for more. |
| Goddamn, goddam, goddamnit, goddammit | awful<br>terrible<br>wretched | This term can be offensive or triggering to some religious traditions because it implies a deity cursing or reproaching people. We want to show respect towards all religious traditions. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concern: Not directly related to the PR, but these are miscategorized. These religion-based lines are under the Racist table.

change (techincally scope creep): Can we add a catch-all table and move the religion ones there?

Copy link
Member Author

@mgwalker mgwalker Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea! I'll create an issue for it. #555

- matches:
- kowtow
- kow tow
- cowtow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change: Add kotow

src/scripts/inclusion-bot.yaml Show resolved Hide resolved
InclusionBot.md Outdated
| jesus fucking, fucking christ | Wow<br>oh no<br>oh my | We want to show respect towards all religious traditions. |
| mumbo jumbo | jargon<br>confusing language | The term ":TERM:" was used to stereotype African languages and cultures that didn't make sense to European colonizers.<br><br>See [some other commonly used terms that have racist origins](https://abcnews.go.com/Politics/commonly-terms-racist-origins/story?id=71840410). |

| kowtow, kow tow, cowtow | submit<br>grovel | The modern usage of this word refers to groveling or submission, which is a disconnect from its real meaning as an act of deep respect. Modern usage of this term misses cultural nuance and perpetuates cultural misunderstanding.<br><br>See [the Slack thread](https://gsa-tts.slack.com/archives/C10EGE62W/p1727210606818389) where teammates discuss the term for more information.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I look at the rendered file (scroll slightly up from this anchor), this line of the table isn't rendering.

I'm seeing a newline at 79, I bet that's the culprit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is intentional. The bot doesn't include anything after the newline, by design. The web table is meant to include history or references for why certain terms are in the bot, and the bot points people to the table to keep the message more compact.

@@ -73,9 +73,11 @@ approves your changes, they will be merged and become active in the bot.
| master/slave, master / slave | primary/secondary<br>primary/replica<br>leader/worker<br>main/replica | This term is rooted in the enslavement of human beings. We want to avoid slavery references.<br><br>See [GitHub to replace "master" with alternative term to avoid slavery references](https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/) for more. |
| open the kimono, open kimono | share information | This term arises from the sexualization of Asian women. We want to avoid sexist, racist, and sexual references.<br><br>See [The Problematic Origins of Common Business Jargon](https://www.fastcompany.com/90239290/six-business-phrases-that-have-racist-origins) for more. |
| grandfathered | legacy<br>included retroactively | This term arose from voter restrictions that prevented Black people from voting. We want to avoid slavery and racist oppression references.<br><br>See [The Problematic Origins of Common Business Jargon](https://www.fastcompany.com/90239290/six-business-phrases-that-have-racist-origins) for more. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change (scope creep): Ever since I started working in a repo that auto-alphabetizes its yaml keys, I'm finding myself wishing these tables were alphabetized by "Instead of". Feel free to ignore that for this PR, I just needed to say it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely ignoring for this PR, but if you wanted to reorder the markdown file, I don't think that'd be a problem! Then locally, we'd delete the yaml file and have it regenerated from the markdown. We'd need to manually re-add the exceptions from the diff, but it should be pretty minor.

@beechnut
Copy link
Contributor

@mgwalker Kind of can't believe you got to this so quickly. Also aren't you on vacation??

@mgwalker
Copy link
Member Author

Yeah, I was on vacation, and I was bored. It turns out programming is one of my happy places.

@mgwalker mgwalker requested a review from beechnut October 15, 2024 15:27
@mgwalker mgwalker merged commit cafa0f1 into main Oct 15, 2024
8 checks passed
@mgwalker mgwalker deleted the update-inclusion-bot branch October 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants