Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @here in holiday reminders #544

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix @here in holiday reminders #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6133bdf
remove attempt to specify @here name
mgwalker Aug 2, 2024
d958a0b
Merge branch 'main' into 511-here-holidays
mgwalker Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scripts/federal-holidays-reminder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const scheduleReminder = (_, config = process.env) => {

await postMessage({
channel: CHANNEL,
text: `<!here|here> Remember that *${holiday.date.format(
text: `<!here> Remember that *${holiday.date.format(
"dddd",
)}* is a federal holiday in observance of *${
holiday.alsoObservedAs ?? holiday.name
Expand Down
6 changes: 3 additions & 3 deletions src/scripts/federal-holidays-reminder.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe("holiday reminder", () => {
expect(postMessage).toHaveBeenCalledWith({
channel: "general",
text: expect.stringMatching(
/^<!here\|here> Remember that \*Thursday\* is a federal holiday in observance of \*test holiday\*! .+$/,
/^<!here> Remember that \*Thursday\* is a federal holiday in observance of \*test holiday\*! .+$/,
),
});

Expand All @@ -127,7 +127,7 @@ describe("holiday reminder", () => {
expect(postMessage).toHaveBeenCalledWith({
channel: "test channel",
text: expect.stringMatching(
/^<!here\|here> Remember that \*Thursday\* is a federal holiday in observance of \*test holiday\*! .+$/,
/^<!here> Remember that \*Thursday\* is a federal holiday in observance of \*test holiday\*! .+$/,
),
});

Expand All @@ -145,7 +145,7 @@ describe("holiday reminder", () => {
expect(postMessage).toHaveBeenCalledWith({
channel: "general",
text: expect.stringMatching(
/^<!here|here> Remember that \*Thursday\* is a federal holiday in observance of \*Veterans Day\* :salute-you:! .+$/,
/^<!here> Remember that \*Thursday\* is a federal holiday in observance of \*Veterans Day\* :salute-you:! .+$/,
),
});

Expand Down
Loading