Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @here in holiday reminders #544

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Fix @here in holiday reminders #544

merged 2 commits into from
Oct 15, 2024

Conversation

mgwalker
Copy link
Member

@mgwalker mgwalker commented Aug 2, 2024

Fixes an issue where @here was showing up as just @. Slack previously supported a mechanism for changing the @here text while preserving the notification. Something changed somewhen, and specifying that alias now seems to result in just the @. So... remove the alias, and we're back in business.

Closes #511


Checklist:

  • Code has been formatted with prettier
  • The OAuth wiki
    page has been updated if Charlie needs any new OAuth events or scopes
  • The Environment Variables
    wiki page has been updated if new environment variables were introduced
    or existing ones changed
  • The dev wiki has been updated, e.g.:
    • local development processes have changed
    • major development workflows have changed
    • internal utilities or APIs have changed
    • testing or deployment processes have changed
  • If appropriate, the NIST 800-218 documentation has been updated

@mgwalker mgwalker requested a review from a team as a code owner August 2, 2024 15:08
@mgwalker mgwalker changed the title remove attempt to specify @here name Fix @here in holiday reminders Aug 2, 2024
@mgwalker mgwalker merged commit 2ac0a6d into main Oct 15, 2024
7 checks passed
@mgwalker mgwalker deleted the 511-here-holidays branch October 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When announcing holidays, Charlie just says @ and not @here
1 participant