Store some client settings #97
Comments
Closed
This was referenced Aug 17, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 2, 2024
We now have dark-theme variants in all the styles that differ between light and dark, in all of the app we've implemented so far. It's time to let users benefit from that work! We don't yet let the user choose between dark/light/system in the app -- that's zulip#97 "Store some client settings" -- but the "system" behavior should be the default anyway, and this commit provides that. The dark-theme colors are picked from various sources. For each color, I believe the source is clear either in the code or the Git history. Those sources are: - the web app (in its state when we wrote the zulip-flutter commit) - the "ready for dev" parts of the new Figma, like this: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2940-48987&m=dev - the table of variables in the new Figma, with a note that we're not sure if we chose the right variable (because the part of the UI doesn't have a "ready for dev" design yet) - my brain. If I couldn't find a better source for a color, I just made one up and checked that it looked OK. We'll want to update the colors as Vlad's work on the new Figma progresses, and also incorporate his feedback from trying out the app in dark theme. Fixes: zulip#95
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 3, 2024
We now have dark-theme variants in all the styles that differ between light and dark, in all of the app we've implemented so far. It's time to let users benefit from that work! We don't yet let the user choose between dark/light/system in the app -- that's zulip#97 "Store some client settings" -- but the "system" behavior should be the default anyway, and this commit provides that. The dark-theme colors come from various sources. For each color, I believe the source is clear either in the code or the Git history. Those sources are: - Flutter's library of Material Design widgets, for UI that's been using those (like the compose box) - the "ready for dev" parts of the new Figma, like this: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2940-48987&m=dev - the web app (in its state when we wrote the zulip-flutter commit) - the table of variables in the new Figma, with a note that we're not sure if we chose the right variable (because that part of the UI doesn't have a "ready for dev" design in the Figma yet) - my brain and a quick check that it looked OK, as a last resort We'll want to update the colors as Vlad's work on the new Figma progresses, and also incorporate his feedback from trying out the app in dark theme. Fixes: zulip#95
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
Aug 9, 2024
We now have dark-theme variants in all the styles that differ between light and dark, in all of the app we've implemented so far. It's time to let users benefit from that work! We don't yet let the user choose between dark/light/system in the app -- that's zulip#97 "Store some client settings" -- but the "system" behavior should be the default anyway, and this commit provides that. The dark-theme colors come from various sources. For each color, I believe the source is clear either in the code or the Git history. Those sources are: - Flutter's library of Material Design widgets, for UI that's been using those (like the compose box) - the "ready for dev" parts of the new Figma, like this: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=2940-48987&m=dev - the web app (in its state when we wrote the zulip-flutter commit) - the table of variables in the new Figma, with a note that we're not sure if we chose the right variable (because that part of the UI doesn't have a "ready for dev" design in the Figma yet) - my brain and a quick check that it looked OK, as a last resort We'll want to update the colors as Vlad's work on the new Figma progresses, and also incorporate his feedback from trying out the app in dark theme. Fixes: zulip#95
|
Filed #1139 for the language setting. |
|
Filed #1216 for the light/dark setting. |
|
Filed #1228 for "Open links with in-app browser". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a handful of user settings that are specific to the client, not to the account, and so we'll want to store locally on the device (following up on #13).
The local settings we have in the zulip-mobile RN app are:
We don't currently have the features that any of those would control:
No need to implement this before we have those; all of them have reasonable defaults we can use, certainly reasonable enough for an alpha. But once we have one or more of those features, then we can add the settings storage and UI for all of them.
The text was updated successfully, but these errors were encountered: