Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open links externally by default on iOS #280

Closed
gnprice opened this issue Aug 17, 2023 · 0 comments · Fixed by #574
Closed

Open links externally by default on iOS #280

gnprice opened this issue Aug 17, 2023 · 0 comments · Fixed by #574
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work
Milestone
M5: Launch

Comments

@gnprice
Copy link
Member

gnprice commented Aug 17, 2023

When opening an external link, we have a choice whether to do so within the app or in an external browser.

Currently we do so following the upstream Flutter defaults documented at launchUrl (except on Android as described at #279). On iOS, that means opening an in-app browser.

But what we chose on zulip-mobile was for the default on iOS to be an external browser, for reasons discussed here in chat, and I think all the same reasoning still applies. So we should do that instead.

Separately:
@gnprice gnprice added the a-iOS Issues specific to iOS, or requiring iOS-specific work label Aug 17, 2023
@gnprice gnprice added this to the Beta milestone Aug 17, 2023
@gnprice gnprice mentioned this issue Aug 17, 2023
Closed
@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Mar 20, 2024
@rajveermalviya
content: Open links externally on iOS
c4d78cd 
On iOS we prefer LaunchMode.externalApplication because LaunchMode.platformDefault
uses SFSafariViewController which provides a weird UX for reasons mentioned
in this discussion:
  https://chat.zulip.org/#narrow/stream/48-mobile/topic/in-app.20browser/near/1169118

Fixes: zulip#280
@rajveermalviya rajveermalviya mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work
Projects
Flutter app
Status: Done
Milestone
M5: Launch
Development

Successfully merging a pull request may close this issue.

content: Open links externally on iOS rajveermalviya/zulip-flutter
1 participant
@gnprice