pull request #43
Open
pull request #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this pull request should be merged. With the original zrax repo, I ran into a pyc file that resulted in pycdc endlessly dumping data to a file. caot's repo fixes that. It also correctly decoded a try: except: that the original repo incorrectly handled. |
|
Thanks for the reminder -- I had forgotten about this PR. Unfortunately, it's a bit hard to review currently, with so many scattered changes (including merges and reverts)... Ideally, I would like to see individual PRs for each major feature or "area" of fixes, which would make it much easier, not only to review, but also to understand the individual changes. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few issues, although there still are some bugs there.