zio 2.1.14, test fixes #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
guizmaii
reviewed
Jan 5, 2025
| @@ -29,7 +29,7 @@ object LoggerNameExtractorSpec extends ZIOSpecDefault { | |||
| } else trace | |||
| } | |||
| val result = extractor( | |||
| Trace.apply(trace, "", 0), | |||
| Trace.apply(trace, "", 1), | |||
There was a problem hiding this comment.
@justcoon Can I ask why you need to change these 0 into 1? 🤔
I made a bunch of changes in zio.Trace but I'm not sure to understand what would require this change here. Did I introduce an issue? 🤔
There was a problem hiding this comment.
hi @guizmaii , look like there is some issue with latest change
import zio.test._
import zio.Trace
object TraceSpec extends ZIOSpecDefault {
val spec: Spec[Environment, Any] = suite("TraceSpec")(
test("line") {
val expected = 0
val trace = Trace.apply("", "", expected)
val line = trace match {
case Trace(_, _, line) => line
case _ => -1
}
assertTrue(line == expected)
}
)
}fail with
Assertion failed:
Expected :0
Actual :-1
<Click to see difference>
✗ -1 was not equal to 0
line == expected
line = -1
however, I guessed that in reality there will not be Trace with line=0, so I just updated tests
There was a problem hiding this comment.
Interesting. I guess the previous behaviour was kind of incorrect as the Trace.unapply should probably have returned None for an empty String, don't you think? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zio 2.1.14, test fixes (Trace.unapply changed, and there were issues with line 0)