Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uri Support #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Uri Support #91

wants to merge 1 commit into from

Conversation

mohammed-rampurawala
Copy link

  • Compressor.java : Added method for compressing and copying the image using the Uri.
  • ImageUti.java : Method to fetch and compress the image using the Uri.

- Compressor.java : Added method for compressing and copying the imag…
bf2f8ae 
…e using the Uri.

- ImageUti.java : Method to fetch and compress the image using the Uri.
DeekshithRajBasa
DeekshithRajBasa reviewed Aug 1, 2019
View reviewed changes
compressor/src/main/java/id/zelory/compressor/ImageUtil.java
BitmapFactory.decodeStream(inputStream, null, options);

// Calculate inSampleSize
options.inSampleSize = calculateInSampleSize(options, reqWidth, reqHeight);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the calculate sample size method?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compressor/compressor/src/main/java/id/zelory/compressor/ImageUtil.java

Line 118 in bf2f8ae

private static int calculateInSampleSize(BitmapFactory.Options options, int reqWidth, int reqHeight) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks 😃

DeekshithRajBasa
DeekshithRajBasa suggested changes Aug 1, 2019
View reviewed changes
Copy link

@DeekshithRajBasa DeekshithRajBasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the method calculate in image size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeekshithRajBasa DeekshithRajBasa DeekshithRajBasa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammed-rampurawala @DeekshithRajBasa