Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remark-numbered-footnotes] Add labelTemplate option #510

Merged
merged 2 commits into from
Apr 20, 2024
Merged

[remark-numbered-footnotes] Add labelTemplate option #510

merged 2 commits into from
Apr 20, 2024

Conversation

TimonPeng
Copy link
Contributor

No description provided.

@StaloneLab
Copy link
Member

Hello there 👋

good PR indeed, especially for a first one! I am not against this feature, and since you already added a test, there is not much to be done. However, I would prefer allowing to set a prefix and a suffix as configuration parameters instead of blindly replacing. It should allow the same as what you are trying to achieve without requiring throwing an error and would be easier to understand.

If you are ready to make this small change, then the feature will be ready to be merged. Please do not worry because of the CI failing, it should be resolved soon (see PR #509 if interested). As long as tests are running fine, I will manually test linting when the PR will be ready (you can also do it by running eslint . at the root of the repository).

One last thing to be done is building the package by running npm run build -- --scope=remark-numbered-footnotes. There is no need to take much time to make it work however: if it does not work at first run, please tell me and I'll do it for you, but seems like you should be able to do it ;)

Thanks again for this nice PR and awaiting your feedback.
-- ლიკა

@TimonPeng
Copy link
Contributor Author

TimonPeng commented Apr 20, 2024

Hi @LikaKavkasidze 👋

Thanks for the good advice! I've changed the options and finished compiling, testing and linting are working fine at the same time, hopefully the CI toolset update will be done soon!

@StaloneLab
Copy link
Member

Thanks for making the requested changes, I will merge your change and release version 3.1.0 of the package in a few minutes!

@StaloneLab StaloneLab merged commit d57a0bc into zestedesavoir:master Apr 20, 2024
2 of 3 checks passed
@TimonPeng TimonPeng deleted the remark-numbered-footnotes branch April 20, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants