Refactor last few tokio specific parts to be runtime agnostic #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
TheButlah
changed the title
Alexei-Kornienko
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #108, this PR refactors the last few places where we bake tokio-specifc functionality into the code, and organizes them into the
async_rtmodule. Theasync_rtmodule will serve as a common denominator between the different runtimes we wish to support, and bundle up any runtime-specific code that we can't accomplish simply with justfutures.The main parts of this are providing a way to spawn and join on tasks in a runtime agnostic way, as well as a minor refactor of a couple things that could be done with
futuresinstead oftokio