Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cross-compilation arch flags for MacOS #622

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Remove cross-compilation arch flags for MacOS #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,6 @@
],
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_ENABLE_EXCEPTIONS': 'YES',
'OTHER_CFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
],
'OTHER_LDFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
]
Comment on lines -137 to -142
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gyp flags are used for ZeroMQ, and build.js is used for libzmq (the upstream library used by ZeroMQ). There's a subtle difference between these two that's sometimes confusion for new contributors.

Copy link
Contributor Author

@rotu rotu Jun 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely confusing to me! Where does the ARCH value here supposedly come from? I was finding it to be blank (on my ARM mac)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARCH is defined in the CI or as an env variable in build.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ARCH is always defined, there should be no need for "<!(echo \"-arch ${ARCH:=x86_64}\")",. It seems odd too that we should have to override the flags instead of simply omitting them.

I'll create an issue for what I thought was a symptom of this.

},
}],

Expand Down Expand Up @@ -227,12 +221,6 @@
'DEAD_CODE_STRIPPING': 'YES',
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
'GCC_ENABLE_EXCEPTIONS': 'YES',
'OTHER_CFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
],
'OTHER_LDFLAGS': [
"<!(echo \"-arch ${ARCH:=x86_64}\")",
]
},
}],

Expand Down
Loading