build: target Node 12 when building

zeromq · Oct 20, 2024 · aa6748d · aa6748d
1 parent 640900f
commit aa6748d
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 53 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -15,8 +15,6 @@ jobs:
         os:
           - ubuntu-20.04
           - windows-2019
-        node_version:
-          - 18
         node_arch:
           - x64
         cpp_arch:
@@ -28,23 +26,19 @@ jobs:
 
         include:
           - os: windows-2019
-            node_version: 18
             node_arch: ia32
             cpp_arch: amd64_x86
 
           # - os: windows-2022
-          #   node_version: 18
           #   node_arch: x64
           #   arch: arm64
           #   cpp_arch: amd64_arm64
 
           - os: macos-13
-            node_version: 18
             node_arch: x64
             cpp_arch: x64
 
           - os: macos-14
-            node_version: 18
             node_arch: arm64
             cpp_arch: amd64_arm64
 
@@ -53,9 +47,8 @@ jobs:
             docker: node:18-alpine
             docker_cmd:
               apk add --no-cache pkgconfig tar python3 build-base cmake ninja
-              zip unzip curl git musl-dev && npm i -g pnpm && pnpm install &&
-              pnpm run build
-            node_version: 18
+              zip unzip curl git musl-dev gcc g++ && npm i -g pnpm && pnpm
+              install && pnpm run build
             node_arch: x64
             cpp_arch: x64
 
@@ -76,9 +69,9 @@ jobs:
             ./build/
           key:
             # prettier-ignore
-            "cache-OS:${{ matrix.os }}-arch:${{ matrix.node_arch}}-ZMQ_DRAFT:${{env.npm_config_zmq_draft }}-Node:${{ matrix.node_version}}-${{hashFiles('./package.json') }}"
+            "cache-OS:${{ matrix.os }}-arch:${{ matrix.node_arch}}-ZMQ_DRAFT:${{env.npm_config_zmq_draft }}-${{hashFiles('./package.json') }}"
           restore-keys: |
-            "cache-OS:${{ matrix.os }}-arch:${{ matrix.node_arch }}-ZMQ_DRAFT:${{ env.npm_config_zmq_draft }}-Node:${{ matrix.node_version }}-"
+            "cache-OS:${{ matrix.os }}-arch:${{ matrix.node_arch }}-ZMQ_DRAFT:${{ env.npm_config_zmq_draft }}-"
 
       - name: Env map
         run: |
@@ -98,18 +91,6 @@ jobs:
           vcpkg: true
           architecture: ${{ matrix.cpp_arch }}
 
-      - uses: pnpm/action-setup@v4
-        if: ${{ !matrix.docker }}
-        with:
-          version: 9
-
-      - name: Install Node
-        if: ${{ !matrix.docker }}
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ matrix.node_version }}
-          architecture: ${{ env.setup_node_arch }}
-
       - name: Install Mac-OS x86_64 Dependencies
         if: ${{ contains(matrix.os, 'macos') && matrix.node_arch == 'x64' }}
         run: |
@@ -123,13 +104,43 @@ jobs:
           echo "PATH=$PATH" >> $GITHUB_ENV
           echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH" >> $GITHUB_ENV
 
+      - uses: pnpm/action-setup@v4
+        if: ${{ !matrix.docker }}
+        with:
+          version: 9
+
+      - name: Install Node 18
+        if: ${{ !matrix.docker }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          architecture: ${{ env.setup_node_arch }}
+
       - name: Install Dependencies
         if: ${{ !matrix.docker }}
         run: pnpm install
 
-      - name: Build
+      - name: Build JavaScript
+        if: ${{ !matrix.docker }}
+        run: pnpm run build.js
+
+      - name: Install Node 12
+        if: ${{ !matrix.docker }}
+        uses: actions/setup-node@v4
+        with:
+          node-version: 12
+          architecture: ${{ env.setup_node_arch }}
+
+      - name: Build Native with Node 12
+        if: ${{ !matrix.docker }}
+        run: npm run build.native
+
+      - name: Use Node 18
         if: ${{ !matrix.docker }}
-        run: pnpm run build
+        uses: actions/setup-node@v4
+        with:
+          node-version: 18
+          architecture: ${{ env.setup_node_arch }}
 
       - name: Prebuild Docker
         if: ${{ matrix.docker }}

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -74,5 +74,5 @@ set_target_properties(addon PROPERTIES PREFIX "" SUFFIX ".node")
 # Windows workaround
 if(WIN32)
   set_property(TARGET addon PROPERTY LINK_FLAGS "-Xlinker /DELAYLOAD:NODE.EXE")
-  target_link_libraries(addon "ShLwApi.lib" "delayimp.lib")
+  target_link_libraries(addon PRIVATE "ShLwApi.lib" "delayimp.lib")
 endif()
diff --git a/README.md b/README.md
@@ -43,10 +43,9 @@ Install **ZeroMQ.js** with prebuilt binaries:
 npm install zeromq
 ```
 
-Requirements for using prebuilt binaries:
+Supported versions:
 
-- Node.js 10.2+ or Electron 3+ (requires a
-  [N-API](https://nodejs.org/api/n-api.html) version 3+)
+- Node.js v12 (requires a [N-API](https://nodejs.org/api/n-api.html))
 
 ### Prebuilt binaries
 

diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     }
   },
   "engines": {
-    "node": ">= 10.2",
+    "node": ">= 12",
     "pnpm": ">= 9"
   },
   "files": [
@@ -123,67 +123,59 @@
     "configurations": [
       {
         "name": "linux-x64",
-        "dev": true,
         "os": "linux",
         "arch": "x64",
         "runtime": "node",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "win-x64",
-        "dev": true,
+        "name": "windows-x64",
         "os": "win32",
         "arch": "x64",
         "runtime": "node",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "macos-x64",
-        "dev": true,
+        "name": "darwin-x64",
         "os": "darwin",
         "arch": "x64",
         "runtime": "node",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "macos-arm64",
-        "dev": true,
+        "name": "darwin-arm64",
         "os": "darwin",
         "arch": "arm64",
         "runtime": "node",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "linux-x64",
-        "dev": true,
+        "name": "linux-x64-electron",
         "os": "linux",
         "arch": "x64",
         "runtime": "electron",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "win-x64",
-        "dev": true,
+        "name": "windows-x64-electron",
         "os": "win32",
         "arch": "x64",
         "runtime": "electron",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "macos-x64",
-        "dev": true,
+        "name": "darwin-x64-electron",
         "os": "darwin",
         "arch": "x64",
         "runtime": "electron",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       },
       {
-        "name": "macos-arm64",
-        "dev": true,
+        "name": "darwin-arm64-electron",
         "os": "darwin",
         "arch": "arm64",
         "runtime": "electron",
-        "runtimeVersion": "14.20.0"
+        "runtimeVersion": "12.22.12"
       }
     ],
     "targetDirectory": "build",