Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed openssh password prompt regex + Added max number of retries ; fix #1904 #1905

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

KenyC
Copy link
Contributor

@KenyC KenyC commented Oct 12, 2023

My ssh doesn't have the password prompt pyzmq expects, which triggers infinite looping (as described in #1904).

> ssh -f 123.123.123.123 -i /path/to/my/key/
Enter passphrase for key '/path/to/my/key/': 
> ssh -V
OpenSSH_8.9p1 Ubuntu-3ubuntu0.4, OpenSSL 3.0.2 15 Mar 2022

I changed the pattern from pass(word|phrase): to pass(word|phrase) to account for my ssh.

I also added a max number of retry to avoid infinite looping, in case future updates also change the phrasing of password prompts.

closes #1904

…o `_try_passwordless_openssh` and `openssh_tunnel` ; fix zeromq#1904
@minrk minrk merged commit 72ba0d5 into zeromq:main Oct 13, 2023
14 checks passed
@minrk
Copy link
Member

minrk commented Oct 13, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: try_passwordless_ssh hangs while connecting to server
2 participants