Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying zip archive fetching of bundled libzmq source in ZMQ_PREFIX #1902

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Support specifying zip archive fetching of bundled libzmq source in ZMQ_PREFIX #1902

merged 3 commits into from
Nov 9, 2023

Conversation

fox4u
Copy link
Contributor

@fox4u fox4u commented Oct 6, 2023 

# zip archives
ZMQ_PREFIX=https://github.com/zeromq/libzmq/archive/ecc63d0.zip

# git clone (default branch latest)
ZMQ_PREFIX=git@https://github.com/zeromq/libzmq

# git clone and checkout some ref
ZMQ_PREFIX=git@https://github.com/zeromq/libzmq@ecc63d0

minrk
minrk reviewed Oct 11, 2023
View reviewed changes
buildutils/bundle.py Outdated Show resolved Hide resolved
buildutils/bundle.py Outdated Show resolved Hide resolved
@minrk minrk mentioned this pull request Oct 11, 2023
Closed
@minrk minrk changed the title Support of git clone and zip archive fetching of bundled libzmq source in ZMQ_PREFIX Support specifying zip archive fetching of bundled libzmq source in ZMQ_PREFIX Nov 9, 2023
@minrk minrk merged commit 4bbf09e into zeromq:main Nov 9, 2023
26 checks passed
@minrk
Copy link
Member

minrk commented Nov 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk minrk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fox4u @minrk