Skip to content

Commit

Permalink
Merge pull request #2041 from minrk/libsodium
Browse files Browse the repository at this point in the history
bump bundled libsodium to 1.0.20
  • Loading branch information
minrk authored Oct 22, 2024
2 parents 63209e4 + a791512 commit b084632
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ option(PYZMQ_LIBZMQ_RPATH "Add $ZMQ_PREFIX/lib to $RPATH (true by default). Set
# anything new should start with PYZMQ_
option(PYZMQ_LIBZMQ_NO_BUNDLE "Prohibit building bundled libzmq. Useful for repackaging, to allow default search for libzmq and requiring it to succeed." OFF)
set(PYZMQ_LIBZMQ_VERSION "4.3.5" CACHE STRING "libzmq version when bundling")
set(PYZMQ_LIBSODIUM_VERSION "1.0.19" CACHE STRING "libsodium version when bundling")
set(PYZMQ_LIBSODIUM_VERSION "1.0.20" CACHE STRING "libsodium version when bundling")
set(PYZMQ_LIBZMQ_URL "" CACHE STRING "full URL to download bundled libzmq")
set(PYZMQ_LIBSODIUM_URL "" CACHE STRING "full URL to download bundled libsodium")
set(PYZMQ_LIBSODIUM_CONFIGURE_ARGS "" CACHE STRING "semicolon-separated list of arguments to pass to ./configure for bundled libsodium")
Expand Down
4 changes: 2 additions & 2 deletions buildutils/bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
repo_root = buildutils.parent.resolve()
licenses = repo_root / "licenses"

bundled_libsodium_version = "1.0.19"
bundled_libsodium_version = "1.0.20"
bundled_version = "4.3.5"


Expand All @@ -28,7 +28,7 @@ def report_version(library="libzmq"):
def fetch_licenses():
"""Download license files for bundled dependencies"""
licenses.mkdir(exist_ok=True)
libsodium_license_url = f"https://raw.githubusercontent.com/jedisct1/libsodium/{bundled_libsodium_version}/LICENSE"
libsodium_license_url = f"https://raw.githubusercontent.com/jedisct1/libsodium/{bundled_libsodium_version}-RELEASE/LICENSE"
libzmq_license_url = (
f"https://raw.githubusercontent.com/zeromq/libzmq/v{bundled_version}/LICENSE"
)
Expand Down
6 changes: 3 additions & 3 deletions docs/source/howto/build.md
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,14 @@ You can specify which version of libsodium/libzmq to bundle with:

```
-DPYZMQ_LIBZMQ_VERSION=4.3.5
-DPYZMQ_LIBSODIUM_VERSION=1.0.19
-DPYZMQ_LIBSODIUM_VERSION=1.0.20
```

or the specify the full URL to download (e.g. to test bundling an unreleased version):

```
-DPYZMQ_LIBZMQ_URL="https://github.com/zeromq/libzmq/releases/download/v4.3.5/zeromq-4.3.5.tar.gz"
-DPYZMQ_LIBSODIUM_URL="https://download.libsodium.org/libsodium/releases/libsodium-1.0.19.tar.gz"
-DPYZMQ_LIBSODIUM_URL="https://download.libsodium.org/libsodium/releases/libsodium-1.0.20.tar.gz"
```

```{warning}
Expand Down Expand Up @@ -246,7 +246,7 @@ PYZMQ_LIBSODIUM_MSBUILD_ARGS:STRING=
PYZMQ_LIBSODIUM_URL:STRING=

# libsodium version when bundling
PYZMQ_LIBSODIUM_VERSION:STRING=1.0.19
PYZMQ_LIBSODIUM_VERSION:STRING=1.0.20

# Visual studio solution version for bundled libsodium (default: detect from MSVC_VERSION)
PYZMQ_LIBSODIUM_VS_VERSION:STRING=
Expand Down
2 changes: 1 addition & 1 deletion docs/source/howto/cross-android.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN make install

# (optional) cross-compile libsodium, libzmq
WORKDIR /src
ENV LIBSODIUM_VERSION=1.0.19
ENV LIBSODIUM_VERSION=1.0.20
RUN curl -L -O "https://download.libsodium.org/libsodium/releases/libsodium-${LIBSODIUM_VERSION}.tar.gz" \
&& tar -xzf libsodium-${LIBSODIUM_VERSION}.tar.gz \
&& mv libsodium-stable libsodium \
Expand Down
2 changes: 1 addition & 1 deletion docs/source/howto/cross.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ WORKDIR /src

# # (optional) cross-compile libsodium, libzmq
# WORKDIR /src
# ENV LIBSODIUM_VERSION=1.0.19
# ENV LIBSODIUM_VERSION=1.0.20
# RUN curl -L -O "https://download.libsodium.org/libsodium/releases/libsodium-${LIBSODIUM_VERSION}.tar.gz" \
# && tar -xzf libsodium-${LIBSODIUM_VERSION}.tar.gz \
# && mv libsodium-stable libsodium \
Expand Down

0 comments on commit b084632

Please sign in to comment.