Zyre binding #133
Zyre binding #133
Conversation
| zend_object zend_object; | ||
| zctx_t *shadow_context; | ||
| zyre_t *zyre; | ||
| zval *internalSocket; |
There was a problem hiding this comment.
Why is this member camelcase and the rest are underscore?
| int data_len, peer_len; | ||
|
|
||
| if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "ss", &peer, &peer_len, &data, &data_len) == FAILURE) { | ||
| RETURN_FALSE; |
There was a problem hiding this comment.
Simple return here as well
|
Hi, looks good! Added a few inline comments. |
|
Hi, |
|
@mkoppanen Well done, Mr travis is green. https://github.com/wysman/php-zmq/blob/zyre/zmq.c#L1987 |
|
I just realize that "zend_throw_exception_ex" do not break the execution flow like C++ exception. |
|
The only book I know is Sara Golemon's book and that's getting a bit dated. |
Add return after zend_throw_exception_ex Remove errno use in zend_throw_exception_ex Remove inline variable declaration
Avoid travis output OK, if the project do not build
| zval_ptr_dtor (&zmq_zyre->internal_socket); | ||
| } | ||
|
|
||
| if (zmq_zyre->zyre != NULL) { |
Conflicts: .travis.yml api.php config.m4 php_zmq_private.h travis/script.sh zmq.c
|
Abandoned? |
|
Hi, I do not have work on this feature for a while, but it was left working and cover with tests units. William |
Add the class ZMQZyre which is a binding of the libzyre. Zyre is an open-source framework for proximity-based peer-to-peer applications. Zyre is based on ZMQ and supported by iMatix.
The ZMQZyre class is add to the php extension if all library dependency are validate, if not this part of the code is disable automatically to avoid build error.