Fix rubocop warnings #2991
Merged
Fix rubocop warnings #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rescuefail is a constant and rubocop says: Naming/ConstantName: Use SCREAMING_SNAKE_CASE for constants.
Mostly autocorrection and what I felt safe to change. There are still warnings beeing suppressed in .rubocop_todo.yml, but this should be in a separate commit.
(or comment why)
- set_cmd isn't realy a pure writer method. Renaming it to process_cmd - mocha does not work with the latest minitest version (rake test won't run), bumping it to Version 2.1
- Leaving extra/rest_client.rb unchanged, as I can't test the syslog functionality for now - Oxidized::Config::* are all constants
- As there were different namings for the rescue exception variables in the code, make them consistent and use "e". - gitcrypt.rb has a nested rescue whih keeps a different variable name (create_error)
- No need to specify Oxidized:: as we already are in the Oxidized Module - Not touching lib/oxidized/config/vars.rb as I don't feel sure about it
The class Nodes inherits Array and as such has the method empty? implemented
|
@ytti and @aschaber1 - if would be great if you would find time to look into this PR. |
Closed
2 tasks
|
I plan to merge this PR next week (starting 11.12.2023) if there is no reaction from the reviewers until then. |
aschaber1
approved these changes
Dec 4, 2023
|
I thought I found serious issue, but I think i''m wrong. I don't see problems, but I'm also not confident as I didn't spend much time and won't spend. But at least someone is doing something, and if something breaks, as long as it gets fixed, that's still progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)Description
This PR fixes a lot of rubocup warnings.
I did not fix all warnings in .rubocop_todo.yml, as I did not felt safe doing so. It would be a better Idea to fix them when touching this part of the code.
I preferred small commits in order to find out a problem easier if there is one. It tried to test as much as possible.
Closes issue #2983