Build nplb hermetically #4587

niranjanyardi · 2024-12-14T04:17:01Z

b/371241293

niranjanyardi · 2024-12-17T09:52:23Z

Would like some initial feedback on the PR.

Please ignore starboard/BUILD.gn - that still needs to be refactored

base/BUILD.gn

y4vor · 2024-12-17T17:03:53Z

base/BUILD.gn

@@ -1641,6 +1649,24 @@ component("base") {
      ]
    }

+    # TODO: b/384652502 - Cobalt: Fix compiler errors building hermetically.
+    if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+      import("//cobalt/build/configs/modular_variables.gni")


shouldn't the import be in the if statement below?

the variable needs to be imported before it can be used. My plan is to remove

import("//cobalt/build/configs/modular_variables.gni")
if (use_custom_libc) {

when the hermetic build is complete.

y4vor · 2024-12-17T17:06:27Z

base/allocator/partition_allocator/BUILD.gn

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")
+    if (use_custom_libc) {
+      deps += [ "//starboard:starboard_group" ]


What does the partition_allocator actually use from //starboard_group?

I got a compiler error, lemme dig that up or amybe this is not needed. I'll double check

y4vor · 2024-12-17T17:07:11Z

base/allocator/partition_allocator/BUILD.gn

@@ -320,6 +330,13 @@ component("partition_alloc") {
    # tagging.cc requires __arm_mte_set_* functions.
    deps += [ "//third_party/android_ndk:cpu_features" ]
  }
+
+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")


Shouldn't the modular_variables.gni be included somewhere early on instead of adding it to every target?

I think andrew was saying we should imported it only where needed. Also, many of these instances will be deleted when hermetically building is complete for all targets

y4vor · 2024-12-17T17:09:12Z

buildtools/third_party/libc++/BUILD.gn

@@ -54,6 +54,13 @@ target(_libcxx_target_type, "libc++") {
    "//build/config:common_deps",
    "//third_party/catapult/devil:devil",
  ]
+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {


What starboard APIs does libc++ use? Maybe we don't need this dependency?

will revisit

niranjanyardi · 2024-12-17T18:46:04Z

build/config/c++/BUILD.gn

+    if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+      import("//cobalt/build/configs/modular_variables.gni")
+      if (use_custom_libc) {
+        cflags_cc += [


this is funky, i tried cflags and that didnt work, i had to split it out . If needed can dig up the error

andrewsavage1 · 2024-12-17T18:00:24Z

buildtools/third_party/libc++/BUILD.gn

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")
+    if (use_custom_libc) {
+      visibility += [ "//starboard:starboard_group" ]


Why does starboard need to depend on this if it's already a dependency of every executable/shlib when use_custom_libcxx is true?

andrewsavage1 · 2024-12-17T18:00:47Z

base/BUILD.gn

@@ -1087,6 +1087,14 @@ component("base") {
    "//third_party/abseil-cpp:absl",
  ]

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")


Throughout this PR, imports should be done at the top of the file

andrewsavage1 · 2024-12-17T18:01:33Z

base/BUILD.gn

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")
+    if (use_custom_libc) {
+      deps -= [ "//base/allocator/partition_allocator:raw_ptr" ]


Should there be a TODO to get this to work?

andrewsavage1 · 2024-12-17T18:02:07Z

base/BUILD.gn

@@ -1087,6 +1087,14 @@ component("base") {
    "//third_party/abseil-cpp:absl",
  ]

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {


Minimize conditional statements by i.e. combining this with the one below (do this in general)

andrewsavage1 · 2024-12-17T19:08:56Z

build/config/c++/BUILD.gn

@@ -92,6 +109,15 @@ config("runtime_library") {
        "m",
        "rt",
      ]
+      if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {


Wouldn't this only be necessary if is_clang is false (which I wouldn't expect)?

andrewsavage1 · 2024-12-17T19:09:38Z

buildtools/third_party/libc++abi/BUILD.gn

+  if (is_cobalt && is_starboard && current_toolchain == cobalt_toolchain) {
+    import("//cobalt/build/configs/modular_variables.gni")
+    if (use_custom_libc) {
+      visibility += [ "//starboard:starboard_group" ]


This also seems strange, let's talk offline

niranjanyardi requested review from a team as code owners December 14, 2024 04:17

niranjanyardi requested a review from johnxwork December 14, 2024 04:17

niranjanyardi marked this pull request as draft December 14, 2024 04:17

niranjanyardi force-pushed the build_hermeticaly branch from 0e0c67d to a61fe7b Compare December 14, 2024 04:19

niranjanyardi changed the title ~~Add buildtools/third_party/libc++/trunk~~ Build base/allocator/partition_allocator:partition_alloc hermetically Dec 14, 2024

niranjanyardi removed the request for review from johnxwork December 14, 2024 04:24

Build nplb hermetically

abaf11c

niranjanyardi force-pushed the build_hermeticaly branch from a61fe7b to abaf11c Compare December 17, 2024 09:50

niranjanyardi changed the title ~~Build base/allocator/partition_allocator:partition_alloc hermetically~~ Build nplb hermetically Dec 17, 2024

niranjanyardi requested review from y4vor, kaidokert and andrewsavage1 December 17, 2024 09:52

y4vor reviewed Dec 17, 2024

View reviewed changes

niranjanyardi commented Dec 17, 2024

View reviewed changes

andrewsavage1 reviewed Dec 17, 2024

View reviewed changes

niranjanyardi mentioned this pull request Dec 17, 2024

Build nplb hermetically #4597

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build nplb hermetically #4587

Build nplb hermetically #4587

niranjanyardi commented Dec 14, 2024 •

edited

Loading

niranjanyardi commented Dec 17, 2024

y4vor Dec 17, 2024

niranjanyardi Dec 17, 2024 •

edited

Loading

y4vor Dec 17, 2024

niranjanyardi Dec 17, 2024 •

edited

Loading

y4vor Dec 17, 2024

niranjanyardi Dec 17, 2024 •

edited

Loading

y4vor Dec 17, 2024

niranjanyardi Dec 17, 2024

niranjanyardi Dec 17, 2024 •

edited

Loading

andrewsavage1 Dec 17, 2024

andrewsavage1 Dec 17, 2024

andrewsavage1 Dec 17, 2024

andrewsavage1 Dec 17, 2024

andrewsavage1 Dec 17, 2024

andrewsavage1 Dec 17, 2024

Build nplb hermetically #4587

Are you sure you want to change the base?

Build nplb hermetically #4587

Conversation

niranjanyardi commented Dec 14, 2024 • edited Loading

niranjanyardi commented Dec 17, 2024

Choose a reason for hiding this comment

niranjanyardi Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niranjanyardi Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niranjanyardi Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niranjanyardi Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niranjanyardi commented Dec 14, 2024 •

edited

Loading

niranjanyardi Dec 17, 2024 •

edited

Loading

niranjanyardi Dec 17, 2024 •

edited

Loading

niranjanyardi Dec 17, 2024 •

edited

Loading

niranjanyardi Dec 17, 2024 •

edited

Loading