Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor with ts #882

Closed

Conversation

bigbigDreamer
Copy link

@bigbigDreamer bigbigDreamer commented Mar 1, 2022

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

#808 Refactor

  • Add basic ts config for lib
  • Sort out the code process
  • Refactor code
  • Unit test
  • Application CodeReview

@redonkulus
Copy link
Contributor

@bigbigDreamer still interesting in this? Or should I close it?

@bigbigDreamer
Copy link
Author

@bigbigDreamer still interesting in this? Or should I close it?

close this, I will open another pr to complete this task.

@redonkulus redonkulus closed this Dec 3, 2022
@koniuszy
Copy link

koniuszy commented Feb 8, 2023

was there a follow up on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants