chore: upgrade to eslint@v9 (#1002)

yahoo · Oct 7, 2024 · 45aae1b · 45aae1b
1 parent 310096e
commit 45aae1b
Show file tree

Hide file tree

Showing 8 changed files with 71 additions and 54 deletions.
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,60 @@
+import js from '@eslint/js';
+import globals from 'globals';
+import reactPlugin from 'eslint-plugin-react';
+
+export default [
+    js.configs.recommended,
+    reactPlugin.configs.flat.recommended,
+    {
+        ignores: [
+            '.idea/',
+            '*-debug.log',
+            'artifacts/',
+            'build/',
+            'components-dist/',
+            'configs/atomizer.json',
+            'dist/',
+            'node_modules/',
+            'npm-*.log',
+            'protractor-batch-artifacts/',
+            'results/',
+            'tests/functional/bootstrap.js',
+        ],
+    },
+    {
+        files: ['**/*.{js,mjs,cjs,jsx,mjsx,ts,tsx,mtsx}'],
+        languageOptions: {
+            ...reactPlugin.configs.flat.recommended.languageOptions,
+            ecmaVersion: 2024,
+            globals: {
+                ...globals.browser,
+                ...globals.jest,
+                ...globals.mocha,
+                ...globals.node,
+                ...globals.protractor,
+            },
+            parserOptions: {
+                ecmaFeatures: {
+                    jsx: true,
+                },
+                sourceType: 'module',
+            },
+        },
+        plugins: {
+            react: reactPlugin,
+        },
+        rules: {
+            indent: [2, 4, { SwitchCase: 1 }],
+            quotes: [0, 'single'],
+            'dot-notation': [2, { allowKeywords: false }],
+            'no-console': 0,
+            'no-prototype-builtins': 0,
+            'no-unexpected-multiline': 0,
+        },
+        settings: {
+            react: {
+                version: 'detect',
+            },
+        },
+    },
+];
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
     "func": "wdio",
     "func:build": "rm -rf tests/functional/dist && npm run build:babel && npm run build:css && npm run build:copy && npm run build:webpack",
     "func:local": "npm run func:build && wdio",
-    "lint": "eslint --ext .js,.jsx . --fix && npm run format:check",
+    "lint": "eslint . --fix && npm run format:check",
     "prepublish": "npm run build",
     "prestart": "npm run prefunc",
     "test": "jest --coverage tests/unit"
@@ -69,9 +69,10 @@
     "babel-jest": "^29.0.0",
     "babel-plugin-add-module-exports": "^1.0.4",
     "chromedriver": "^129.0.0",
-    "eslint": "^8.0.0",
-    "eslint-plugin-react": "^7.19.0",
+    "eslint": "^9.0.0",
+    "eslint-plugin-react": "^7.37.1",
     "gh-pages": "^6.0.0",
+    "globals": "^15.10.0",
     "jest": "^29.0.0",
     "jest-environment-jsdom": "^29.0.0",
     "mocha": "^10.0.0",

diff --git a/src/Sticky.jsx b/src/Sticky.jsx
@@ -238,6 +238,7 @@ class Sticky extends Component {
                     // Commentting out "break" is on purpose, because there is a chance to transit to FIXED
                     // from ORIGINAL when calling window.scrollTo().
                     // break;
+                    /* eslint-disable-next-line no-fallthrough */
                     case STATUS_RELEASED:
                         // If "top" and "bottom" are inbetween stickyTop and stickyBottom, then Sticky is in
                         // RELEASE status. Otherwise, it changes to FIXED status, and its bottom sticks to
@@ -492,6 +493,7 @@ Sticky.defaultProps = {
  *        Could be a selector representing a node whose bottom should serve as the bottom boudary.
  */
 Sticky.propTypes = {
+    children: PropTypes.elementType,
     enabled: PropTypes.bool,
     top: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
     bottomBoundary: PropTypes.oneOfType([

diff --git a/tests/functional/sticky-functional.jsx b/tests/functional/sticky-functional.jsx
@@ -1,3 +1,4 @@
+/* eslint-disable react/react-in-jsx-scope,react/prop-types */
 const classNames = require('classnames');
 const Sticky = require('../../../dist/cjs/Sticky');
 

diff --git a/tests/unit/Sticky.test.js b/tests/unit/Sticky.test.js
@@ -504,6 +504,7 @@ describe('Sticky', () => {
             render() {
                 return (
                     <Sticky
+                        /* eslint-disable-next-line react/no-string-refs */
                         ref="sticky"
                         bottomBoundary={`#boundary{this.state.boundary}`}
                         enabled={this.state.enabled}

diff --git a/wdio.conf.js b/wdio.conf.js
@@ -16,16 +16,16 @@ const config = {
 
 if (process.env.CI) {
     // Saucelabs configuration
-    (config.capabilities = [
+    config.capabilities = [
         {
             acceptInsecureCerts: true,
             browserName: 'chrome',
             browserVersion: 'latest',
             maxInstances: 5,
             platformName: 'Windows 10',
         },
-    ]),
-        (config.key = process.env.SAUCE_ACCESS_KEY);
+    ];
+    config.key = process.env.SAUCE_ACCESS_KEY;
     config.services = [
         [
             'sauce',