Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOADOUTS] Use new loadouts with multiple spawn sections, add loadout generation logics placeholders. #111

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Neloreck
Copy link
Member

@Neloreck Neloreck commented Jan 3, 2025

Changes

  • Correct generation of loadout sections with JSX utils, add assertions and validation
  • Corrected already used loadouts for char descriptions
  • Added handler for loadout generation callback / manager to handle layouts

Checklist

  • tests are included
  • documentation is changed or added

Links / references

Blocked by: OpenXRay/xray-16#1590

@Neloreck Neloreck self-assigned this Jan 3, 2025
@github-actions github-actions bot added test Changes are updating or introducing unit tests managers Changes are affecting game managers scripts configs Changes are affecting ltx configuration labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.06%. Comparing base (e6920f6) to head (1f37e4c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   73.05%   73.06%           
=======================================
  Files        1310     1312    +2     
  Lines       37016    37028   +12     
  Branches     6268     6266    -2     
=======================================
+ Hits        27041    27053   +12     
  Misses       9975     9975           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configs Changes are affecting ltx configuration managers Changes are affecting game managers scripts test Changes are updating or introducing unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant