Skip to content

Commit

Permalink
fix attempt2 for empty function namespace
Browse files Browse the repository at this point in the history
  • Loading branch information
fzumstein committed Dec 8, 2024
1 parent 3039975 commit 56573af
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions app/templates/manifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<Metadata>
<SourceLocation resid="Functions.Metadata.Url" />
</Metadata>
{% if settings.functions_namespace %}
{% if settings.functions_namespace or settings.environment != 'prod' %}
<Namespace resid="Functions.Namespace" />
{% endif %}
</ExtensionPoint>
Expand Down Expand Up @@ -127,8 +127,8 @@
<bt:Url id="Functions.Metadata.Url" DefaultValue="{{ base_url_with_app_path }}/xlwings/custom-functions-meta.json" />
</bt:Urls>
<bt:ShortStrings>
{% if settings.functions_namespace %}
<bt:String id="Functions.Namespace" DefaultValue="{{ settings.functions_namespace|upper }}{{ '_' if settings.functions_namespace and settings.environment != 'prod'}}{{ settings.environment | upper if settings.environment != 'prod'}}" />
{% if settings.functions_namespace or settings.environment != 'prod' %}
<bt:String id="Functions.Namespace" DefaultValue="{{ settings.functions_namespace|upper }}{{ '_' if settings.functions_namespace and settings.environment != 'prod'}}{{ settings.environment|upper if settings.environment != 'prod'}}" />
{% endif %}
<bt:String id="MyTab.TabLabel" DefaultValue="{{ settings.project_name }}{{ ' [' + settings.environment + ']' if settings.environment != 'prod'}}" />
<bt:String id="MyCommandsGroup.Label" DefaultValue="MyGroup" />
Expand All @@ -144,7 +144,7 @@
{% if "entraid" in settings.auth_providers %}
<WebApplicationInfo>
<Id>{{ settings.auth_entraid_client_id }}</Id>
<Resource>api://{{ base_url_with_app_path | replace("https://", "") }}/{{ settings.auth_entraid_client_id }}</Resource>
<Resource>api://{{ base_url_with_app_path|replace("https://", "") }}/{{ settings.auth_entraid_client_id }}</Resource>
<Scopes>
<Scope>openid</Scope>
<Scope>profile</Scope>
Expand Down

0 comments on commit 56573af

Please sign in to comment.