This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Fixes #61 #81
Open
Fixes #61 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi David, This looks like it might be a good commit to me. But, it's honestly been so long since I've worked with this code that I don't remember much of how it works. You probably understand it better than me at this point. So, I've invited you to be a contributor to this project. Feel free to merge your pull request. Then, if you find that it has other, undesired effects, you can fix them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix the memory leak caused by calling
GetDocument()on aDocumentor having aDocumentreturned by a call toParent()on aNode, as explained in #61.I don't know whether it has other, undesired effects.