Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosts for detached steps #4674

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

qwerty287
Copy link
Contributor

closes #4627

@stevapple Once the CI finished, can you test this with the PR tag?

@qwerty287 qwerty287 added bug Something isn't working backend/kubernetes build_pr_images If set, the CI will build images for this PR and push to Dockerhub labels Jan 6, 2025
@qwerty287 qwerty287 requested a review from a team January 6, 2025 08:26
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.16%. Comparing base (d126cf9) to head (c58fa62).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/backend/kubernetes/kubernetes.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4674   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         398      398           
  Lines       28205    28205           
=======================================
  Hits         7944     7944           
  Misses      19555    19555           
  Partials      706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevapple
Copy link
Contributor

@qwerty287 While I cannot test this in production, it looks fairly correct to me👍

@qwerty287 qwerty287 merged commit 0fba54d into woodpecker-ci:main Jan 6, 2025
8 of 9 checks passed
@qwerty287 qwerty287 deleted the kube-detached branch January 6, 2025 16:06
@woodpecker-bot
Copy link
Collaborator

@woodpecker-bot woodpecker-bot mentioned this pull request Jan 6, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes bug Something isn't working build_pr_images If set, the CI will build images for this PR and push to Dockerhub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A detached container cannot be accessed (at least with Kubernetes backend)
4 participants