feat: add linter support for step-level depends_on existence
#4657
Conversation
| @@ -94,6 +94,9 @@ func (l *Linter) lintFile(config *WorkflowConfig) error { | |||
| if err := l.lintContainers(config, "services"); err != nil { | |||
| linterErr = multierr.Append(linterErr, err) | |||
| } | |||
| if err := l.lintDependsOn(config); err != nil { | |||
There was a problem hiding this comment.
Can you move this call into lintContainers?
There was a problem hiding this comment.
I'm a little bit hesitant because currently we only support depends_on for steps, and it's unclear how dependencies across areas work (they should). Both of them make depends_on check different from other lintContainers check that's restricted to each area or even a single container.
There was a problem hiding this comment.
Well, you're just linting the containers. Yes, it's different for the areas, but can't you just add an if to only run that for the steps area?
There was a problem hiding this comment.
Not sure if this is what you expect…?
There was a problem hiding this comment.
Yes, basically, that's what I mean.
But can you move the if statemrnt to lintContainer as well?
qwerty287
changed the title
depends_on existencedepends_on existence
stevapple
force-pushed
the
lint-depends
branch
from
af44627 to
7bb8080
Compare
RT. This is useful as one could typo or forget to update the name everywhere.
Note that this PR is not implementing #1139, which is otherwise at workflow level.