pin containerd-shim to <2 and remove k3s-images subpackage #35306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerd-shim-runc-v2 is now pulling in versions > 2.0.0 by default. (containerd/containerd#10984) pinning is required because any version >2.0.0 is not compatible with daemon < 2.0.0 daemon in this case is coming from k3s itself and upstream k3s project have not migrated yet to version > 2.0.0 there's is an issue tracking k3s update to containerd > 2.0.0 (k3s-io/k3s#11375) remove pin once upstream migrates to containerd > 2.0.0 Signed-off-by: kranurag7 <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: kranurag7 <[email protected]> Co-authored-by: Josh Wolf <[email protected]>
octo-sts
bot
added
the
bincapz/pass
kranurag7
changed the title
Signed-off-by: kranurag7 <[email protected]> Co-authored-by: Josh Wolf <[email protected]>
kranurag7
commented
Nov 27, 2024
joshrwolf
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes:
containerd-shim-runc-v2 is now pulling in versions > 2.0.0 by default. (containerd/containerd#10984)
pinning is required because any version >2.0.0 is not compatible with daemon < 2.0.0
daemon in this case is coming from k3s itself and upstream k3s project have not migrated yet to version > 2.0.0
there's is an issue tracking k3s update to containerd > 2.0.0 (k3s-io/k3s#11375)
remove pin once upstream migrates to containerd > 2.0.0
this also removes k3s-images subpackage because we no longer have those images available.