Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search #878

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Add search #878

merged 1 commit into from
Aug 29, 2017

Conversation

alexispurslane
Copy link

Added the search function using codemirror's add-ons, as per issue #799.

@joshuafcole
Copy link
Contributor

joshuafcole commented Aug 29, 2017

  • Let's add an opaque white background to the searchbox. If you scroll down and invoke it while it's above text, it's quite hard to read.
  • Let's also add the matches on scrollbar plugin to make the fact that we're still in search mode a little more obvious.

Other than that, looks good!

@alexispurslane
Copy link
Author

alexispurslane commented Aug 29, 2017 via email

@alexispurslane
Copy link
Author

Okay, I've made both of these changes, but for some inexplicable reason, package.json is reformatted and examples/quickstart.eve is... changed? How should I reset those files?

Copy link
Contributor

@joshuafcole joshuafcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the src/.DS_Store file that snuck in, and then this is ready to merge!

Copy link
Contributor

@joshuafcole joshuafcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@joshuafcole joshuafcole merged commit 5497a1f into witheve:release Aug 29, 2017
@alexispurslane alexispurslane deleted the add_search branch August 29, 2017 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants