Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm-publish.yml #8

Closed
wants to merge 1 commit into from
Closed

Conversation

kurayami07734
Copy link
Collaborator

Publish action would get triggered by release and not by merge to main branch

Changes

Updated the npm publish action such that it publishes after every merge to the main branch

changed the npm publish action such that it publishes after every merge to the main branch
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, are you sure about that? It basically means switching to continuous delivery. It is totally possible, but in such a case one would need to automatically increment versions and, nice to have, publish changelogs (see Release Drafter in other projects in this org). If you publish like that, it will override the version with new content which is something I would advice against

@kurayami07734
Copy link
Collaborator Author

Hello, are you sure about that? It basically means switching to continuous delivery.

I wanted your opinion on this, actually

I was confused on how I was supposed to create releases

@oleg-nenashev
Copy link
Member

As discussed on Slack, I would recommend a pipeline driven by GitHub Releases

  1. Changelog Drafter is used to generate draft changelogs
  2. Once you are ready to release, you just publish the draft changelog
  3. A Release GitHub Action is triggered upon publishing the release, and does the build and deployment for the selected version

See https://github.com/wiremock/python-wiremock for the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants