-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create npm-publish.yml #7
Conversation
adding github action for automating npm publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #5 @oleg-nenashev we need to setup npm access token as actions secret for this action to work |
@kurayami07734 Deploy tokens are associated to users, so normally you should be able to add one. I will double-check what happens there. Please also add the organization scope ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to indicate an update is needed before the merge
added name of npm access token Co-authored-by: Oleg Nenashev <[email protected]>
adding github action for automating npm publish
Need
PS
I also wanted to know what all versions of node we are going to target?
(Might need to add babel)