Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create npm-publish.yml #7

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Create npm-publish.yml #7

merged 3 commits into from
Oct 29, 2023

Conversation

kurayami07734
Copy link
Collaborator

@kurayami07734 kurayami07734 commented Oct 26, 2023

adding github action for automating npm publish

Need

  • npm auth token

PS
I also wanted to know what all versions of node we are going to target?
(Might need to add babel)

adding github action for automating npm publish
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleg-nenashev oleg-nenashev added hacktoberfest-accepted Accepting PRs for hacktoberfest chore Maintenance labels Oct 28, 2023
@kurayami07734
Copy link
Collaborator Author

Closes #5

@oleg-nenashev we need to setup npm access token as actions secret for this action to work

@oleg-nenashev
Copy link
Member

@kurayami07734 Deploy tokens are associated to users, so normally you should be able to add one. I will double-check what happens there. Please also add the organization scope (@wiremock) to the metadata: https://docs.npmjs.com/about-organization-scopes-and-packages

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to indicate an update is needed before the merge

added name of npm access token

Co-authored-by: Oleg Nenashev <[email protected]>
@kurayami07734 kurayami07734 merged commit 9ad394b into main Oct 29, 2023
1 check passed
@kurayami07734 kurayami07734 deleted the gha-npm-publish branch October 29, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance hacktoberfest-accepted Accepting PRs for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants