Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_includeDefaultValueFields_flag #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SkyRaider56
Copy link

There are many situations, where you need to have all fields with default values being contained to json
So there is a flag, which allow you to do it. Its easy to do it for example in docker-compose:

image

References

  • TODO

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@snova-kristina
Copy link

I use wiremock-grpc-extension in my work and find SkyRaider's feature very useful!!
Hope you'll add it to the release 🙏🏻

@leeturner
Copy link
Collaborator

Hi, many thanks for your contribution. Overall the addition of includingDefaultValueFields seems like a good addition. However, we tend not to use env variables in this way to accomplish this. We need to make sure that we are catering for people who are using the extension standalone, programatically using something like JUnit or in docker etc. In Wiremock core we have the Options interface for this and we were wondering if something like this would be worth exploring here? The extension interface could be extended to allow options to be passed in and default options to be loaded (env vars for standalone for example). Is this something you would like to explore implementing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants