Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WIREMOCK_OPTIONS duplicated #92

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

jerosa
Copy link
Contributor

@jerosa jerosa commented Oct 20, 2023

References

Bug: #91

When passing the wiremock options sometimes fail. This is due the WIREMOCK_OPTIONS being duplicated. I've tested it in the entry point.sh adding -x for tracing.

❯ docker run -e WIREMOCK_OPTIONS='--container-threads=100 --verbose' wiremock/wiremock:test-opts
+ '[' '' = '' -o '' = - ']'
+ set -- java -cp '/var/wiremock/lib/*:/var/wiremock/extensions/*' wiremock.Run --container-threads=100 --verbose
+ '[' '' '!=' '' ']'
+ exec java -cp '/var/wiremock/lib/*:/var/wiremock/extensions/*' wiremock.Run --container-threads=100 --verbose --container-threads=100 --verbose
2023-10-20 09:25:02.700 Verbose logging enabled
Exception in thread "main" 
Exception: java.util.MissingResourceException thrown from the UncaughtExceptionHandler in thread "main"

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@kapishmalik
Copy link
Contributor

kapishmalik commented Oct 21, 2023

@jerosa thanks for fixing this. You also need to fix in this file as well - https://github.com/wiremock/wiremock-docker/blob/main/alpine/docker-entrypoint.sh

@jerosa
Copy link
Contributor Author

jerosa commented Oct 22, 2023

@kapishmalik solved also in that file

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Indeed, it would lead to duplication

@oleg-nenashev oleg-nenashev merged commit b6dcacf into wiremock:main Oct 23, 2023
2 checks passed
@jerosa jerosa deleted the patch-1 branch October 23, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants