Increase retry_count for server_running to 10 to account for slower startup times of Wiremock #112
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using python-wiremock in a project I'm working on. When running with docker-desktop it works fine, but when I switch to colima as the host it appears that it takes slightly longer for the Wiremock server to get ready in the container. I'm running on an M2 Mac.
This is the error I get:
If I go in to the
server_running
function in python-wiremock and manually bump up theretry_count
to 10 (as per this PR) then it works fine, on the 4th attempt it successfully connects to wiremock.I think a cleaner solution to my problem would be if we could expose the
retry_count
as configuration, but I don't have the time to contribute such a major change at the moment. This would solve my problem in the short term, at least.References
No relevant references
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java