Update the docker compose command for the integration tests #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github no longer support the `docker-compose` command. They have moved to the `docker compose` version instead
alexjircan
approved these changes
Dec 16, 2024
alexjircan
reviewed
Dec 16, 2024
.github/workflows/tests.yml
Outdated
| @@ -45,5 +45,5 @@ jobs: | |||
| - name: Integration Tests | |||
| run: | | |||
| cd examples/ | |||
There was a problem hiding this comment.
Shouldn't we use cd examples/intro/ here?
There was a problem hiding this comment.
And in docker-compose.yml also we should change the context from ../ to ../../
There was a problem hiding this comment.
Hey, yeah, I think you are correct. I am not really that proficient with the python project at the moment so wasn't aware that these were broken. Let me update them and see if that fixes the issue
Also fixed the context in the examples docker file
6 tasks
|
Also, I think we have to change |
alexjircan
reviewed
Dec 16, 2024
Co-authored-by: Alexandru Jircan <[email protected]>
|
@alexjircan Many thanks for your support on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the github actions test run to use the newer version of the command