Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up charts #46

Merged
merged 1 commit into from
Sep 16, 2024
Merged

cleaned up charts #46

merged 1 commit into from
Sep 16, 2024

Conversation

gitkent
Copy link
Collaborator

@gitkent gitkent commented Sep 12, 2024

Cleaned up unwanted charts.

References

#43 (comment)

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@gitkent gitkent added the chore Maintenance label Sep 12, 2024
@gitkent gitkent requested a review from leeturner September 12, 2024 12:13
Copy link
Contributor

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitkent There is an issue with the index in gh-pages: the older versions 0.1.0 to 0.1.3 have a wrong link to download the file
See https://github.com/wiremock/helm-charts/blob/gh-pages/index.yaml#L121-L148
Example: https://gitkent.github.io/helm-charts/wiremock-0.1.3.tgz

v01.3 might be updated to use the release artifact, but the other 0.1.0, 0.1.1 and 0.1.2 need a new link

@gitkent
Copy link
Collaborator Author

gitkent commented Sep 13, 2024

@gitkent There is an issue with the index in gh-pages: the older versions 0.1.0 to 0.1.3 have a wrong link to download the file See https://github.com/wiremock/helm-charts/blob/gh-pages/index.yaml#L121-L148 Example: https://gitkent.github.io/helm-charts/wiremock-0.1.3.tgz

v01.3 might be updated to use the release artifact, but the other 0.1.0, 0.1.1 and 0.1.2 need a new link

We will need another PR to fix that as the PR will need to merge into gh-pages branch not master branch. also we may have to retire version 0.1.0, 0.1.1 ad 0.1.2 since the oldest link we can get from github release is only 0.1.3 as in here: https://github.com/wiremock/helm-charts/releases.

@DanielFran
Copy link
Contributor

DanielFran commented Sep 13, 2024

@gitkent Probably it is easier to remove all links prior 0.1.3 version and just update the link for 0.1.3

@gitkent gitkent merged commit 0082150 into master Sep 16, 2024
1 check passed
@gitkent gitkent deleted the housekeeping branch September 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants