Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating additional values #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rliskunov
Copy link

I'm using additional variables inside values.yaml.

For example, domain: {{ .Chart.Name }}.{{ .Values.ingress.stage }} and I add it to ingress.hosts[0].{{ domain }}.

However, the values are not substituted after templating. This is due to the lack of a call to the tpl function. This Pull Request is designed to solve this problem

Additionally, I put .gitignore to exclude unused files from the repository.

References

  • Personal problem in my pet project

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@rliskunov rliskunov requested a review from gitkent as a code owner February 25, 2024 14:43
Copy link
Collaborator

@gitkent gitkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rliskunov thanks for your PR. A few things here:

  • please remove the .gitignore file as it is specific to your local setup but not helm related
  • please keep correct and indentation, ideally we want to keep the original indentation
  • for your templating issue, please elaborate more about what you are trying to achieve? As most of the YAML templates were generated from helm create command. It would be cleaner to keep the original unless there is a real necessity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants