Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic ci #56

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

oskardotglobal
Copy link
Member

Basic CI that builds winapps, just 2 binaries for now; an x86 linux binary and an experimental aarch64 one (built on musl, should have excellent support anywhere)
We could probably remove the aarch64 one, but we could also keep it for now
The way this works is once a release is created, the action will automatically attach the files + sha256 hashes to the release

@AkechiShiro
Copy link

Is there anything, that I should do to help with this merge? I believe the CI action is alright for now.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
@oskardotglobal
Copy link
Member Author

Alright, dropping aarch64 in favour of i686 (this seems to be the 32-bit variant afaik) because freerdp seems to not actually support aarch64 from what I've seen

@oskardotglobal
Copy link
Member Author

I also added musl binaries just in case; especially thin clients will profit from this

@oskardotglobal
Copy link
Member Author

oh also because we don't have any packages yet I added a curl-bash script for installation; it will also install quickemu using the other script

Copy link
Member

@LDprg LDprg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. In future we may replace the install.sh with a python script, in order to uniform things a bit (So we have rust for compiled and python for scripting).

@oskardotglobal oskardotglobal merged commit e9b1da7 into winapps-org:rewrite Nov 7, 2023
3 checks passed
@oskardotglobal oskardotglobal added enhancement New feature or request rewrite Using the winapps rewrite labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rewrite Using the winapps rewrite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants