Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-7143] Consolidate HostControllerBootstrap and EmbeddedHostCon… #6325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WFCORE-7143] Consolidate HostControllerBootstrap and EmbeddedHostCon… #6325

wants to merge 1 commit into from

Conversation

bstansberry
Copy link
Contributor

@bstansberry
Copy link
Contributor Author

@yersan @luck3y @jamezp FYI.

@jamezp
Copy link
Member

jamezp commented Jan 21, 2025

The failure seems like it might be related.

luck3y
luck3y approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@luck3y luck3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should be fine to me, don't see anything obvious :)

@wildfly-ci
Copy link

Core -> Full Integration Build 14243 outcome was FAILURE using a merge of ee692e2
Summary: Tests failed: 2 (2 new), passed: 4560, ignored: 55 Build time: 02:51:31

Failed tests

org.jboss.as.test.clustering.cluster.jsf.ProtoStreamJSFFailoverTestCase.testGracefulSimpleFailover: java.lang.AssertionError: expected:<200> but was:<500>
	at org.jboss.as.test.clustering.cluster.jsf.AbstractJSFFailoverTestCase.testGracefulSimpleFailover(AbstractJSFFailoverTestCase.java:178)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
------- Stdout: -------
node-2 2025-01-21 22:37:36,781 INFO  [org.jboss.as.repository] (management-handler-thread - 2) WFLYDR0001: Content added at location /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-jsf-2/standalone/data/content/e2/b60d83d4cc041cf41472bf75c66014da46a8b8/content
node-2 2025-01-21 22:37:36,784 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-4) WFLYSRV0027: Starting deployment of "ProtoStreamJSFFailoverTestCase.war" (runtime-name: "ProtoStreamJSFFailoverTestCase.war")
node-2 2025-01-21 22:37:36,945 INFO  [org.jboss.weld.deployer] (MSC service thread 1-4) WFLYWELD0003: Processing weld deployment ProtoStreamJSFFailoverTestCase.war
node-2 2025-01-21 22:37:37,211 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 8) WFLYCLJG0032: Connecting 'ee' channel. 'node-2' joining cluster 'ejb' via /[0:0:0:0:0:0:0:1]:7700
node-2 2025-01-21 22:37:37,211 INFO  [org.jgroups.JChannel] (ServerService Thread Pool -- 8) local_addr: 18e1ee0d-7071-441a-9b7e-25156ffef0a6, name: node-2
node-2 2025-01-21 22:37:37,233 INFO  [org.jgroups.protocols.FD_SOCK2] (ServerService Thread Pool -- 8) server listening on /[0:0:0:0:0:0:0:1]:57700
node-2 2025-01-21 22:37:39,238 INFO  [org.jgroups.protocols.pbcast.GMS] (ServerService Thread Pool -- 8) node-2: no members discovered after 2001 ms: creating cluster as coordinator
node-2 2025-01-21 22:37:39,240 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 8) WFLYCLJG0033: Connected 'ee' channel. 'node-2' joined cluster 'ejb' with view: [node-2|0] (1) [node-2]
node-2 2025-01-21 22:37:39,314 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 21) ISPN000556: Starting user marshaller 'org.wildfly.clustering.cache.infinispan.marshalling.UserMarshaller'
node-2 2025-01-21 22:37:39,323 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 21) ISPN000389: Loaded global state, version=15.0.11.Final timestamp=2025-01-21T22:37:36.307937358Z
node-2 2025-01-21 22:37:39,345 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 21) Started web cache container
node-2 2025-01-21 22:37:39,353 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 21) ISPN000025: wakeUpInterval is <= 0, not starting expired purge thread
node-2 2025-01-21 22:37:39,359 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 21) WFLYCLINF0002: Started ProtoStreamJSFFailoverTestCase.war cache from web container
node-2 2025-01-21 22:37:39,362 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 8) WFLYCLINF0002: Started default-server cache from web container
node-2 2025-01-21 22:37:39,389 INFO  [jakarta.enterprise.resource.webcontainer.faces.config] (ServerService Thread Pool -- 8) Initializing Mojarra 4.0.8 for context '/ProtoStreamJSFFailoverTestCase'
node-2 2025-01-21 22:37:39,436 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 8) WFLYUT0021: Registered web context: '/ProtoStreamJSFFailoverTestCase' for server 'default-server'
node-2 2025-01-21 22:37:39,462 INFO  [org.jboss.as.server] (management-handler-thread - 2) WFLYSRV0010: Deployed "ProtoStreamJSFFailoverTestCase.war" (runtime-name : "ProtoStreamJSFFailoverTestCase.war")
node-1 2025-01-21 22:37:39,514 INFO  [org.jboss.as.repository] (management-handler-thread - 1) WFLYDR0001: Content added at location /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-clustering-jsf-1/standalone/data/content/34/67bf9ab77fbf006969713de2d600c6f3b82c37/content
node-1 2025-01-21 22:37:39,519 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-1) WFLYSRV0027: Starting deployment of "ProtoStreamJSFFailoverTestCase.war" (runtime-name: "ProtoStreamJSFFailoverTestCase.war")
node-1 2025-01-21 22:37:39,679 INFO  [org.jboss.weld.deployer] (MSC service thread 1-6) WFLYWELD0003: Processing weld deployment ProtoStreamJSFFailoverTestCase.war
node-1 2025-01-21 22:37:39,974 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 19) WFLYCLJG0032: Connecting 'ee' channel. 'node-1' joining cluster 'ejb' via /[0:0:0:0:0:0:0:1]:7600
node-1 2025-01-21 22:37:39,975 INFO  [org.jgroups.JChannel] (ServerService Thread Pool -- 19) local_addr: 5f6c3089-09fd-4157-94f8-8da2e58c70f5, name: node-1
node-1 2025-01-21 22:37:39,985 INFO  [org.jgroups.protocols.FD_SOCK2] (ServerService Thread Pool -- 19) server listening on /[0:0:0:0:0:0:0:1]:57600
node-2 2025-01-21 22:37:40,003 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) ISPN100000: Node node-1 joined the cluster
node-2 2025-01-21 22:37:40,004 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) ISPN100000: Node node-1 joined the cluster
node-1 2025-01-21 22:37:40,046 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 19) WFLYCLJG0033: Connected 'ee' channel. 'node-1' joined cluster 'ejb' with view: [node-2|1] (2) [node-2, node-1]
node-1 2025-01-21 22:37:40,118 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 20) ISPN000556: Starting user marshaller 'org.wildfly.clustering.cache.infinispan.marshalling.UserMarshaller'
node-1 2025-01-21 22:37:40,126 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 20) ISPN000389: Loaded global state, version=15.0.11.Final timestamp=2025-01-21T22:37:36.714093647Z
node-2 2025-01-21 22:37:40,143 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) [Context=org.infinispan.CONFIG] ISPN100002: Starting rebalance with members [node-2, node-1], phase READ_OLD_WRITE_ALL, topology id 2
node-2 2025-01-21 22:37:40,144 INFO  [org.infinispan.LIFECYCLE] (thread-5,null,node-2) [Context=org.infinispan.CONFIG] ISPN100002: Starting rebalance with members [node-2, node-1], phase READ_OLD_WRITE_ALL, topology id 2
node-2 2025-01-21 22:37:40,146 INFO  [org.infinispan.LIFECYCLE] (non-blocking-thread-node-2-p17-t6) [Context=org.infinispan.CONFIG] ISPN100010: Finished rebalance with members [node-2, node-1], topology id 2
node-1 2025-01-21 22:37:40,188 INFO  [org.infinispan.LIFECYCLE] (thread-5,null,node-1) [Context=org.infinispan.CONFIG] ISPN100002: Starting rebalance with members [node-2, node-1], phase READ_OLD_WRITE_ALL, topology id 2
node-1 2025-01-21 22:37:40,193 INFO  [org.infinispan.LIFECYCLE] (non-blocking-thread-node-1-p17-t5) [Context=org.infinispan.CONFIG] ISPN100010: Finished rebalance with members [node-2, node-1], topology id 2
node-2 2025-01-21 22:37:40,239 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) [Context=org.infinispan.CONFIG] ISPN100009: Advancing to rebalance phase READ_ALL_WRITE_ALL, topology id 3
node-2 2025-01-21 22:37:40,248 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) [Context=org.infinispan.CONFIG] ISPN100009: Advancing to rebalance phase READ_NEW_WRITE_ALL, topology id 4
node-2 2025-01-21 22:37:40,292 INFO  [org.infinispan.CLUSTER] (thread-5,null,node-2) [Context=org.infinispan.CONFIG] ISPN100010: Finished rebalance with members [node-2, node-1], topology id 5


org.wildfly.test.integration.observability.opentelemetry.OpenTelemetryMetricsTestCase(layers-test).getMetrics: java.lang.AssertionError: Missing metric: testCounter
	at org.wildfly.test.integration.observability.opentelemetry.OpenTelemetryMetricsTestCase.lambda$getMetrics$1(OpenTelemetryMetricsTestCase.java:68)
	at java.base/java.lang.Iterable.forEach(Iterable.java:75)
	at org.wildfly.test.integration.observability.opentelemetry.OpenTelemetryMetricsTestCase.lambda$getMetrics$2(OpenTelemetryMetricsTestCase.java:68)
	at org.jboss.as.test.shared.observability.containers.OpenTelemetryCollectorContainer.assertMetrics(OpenTelemetryCollectorContainer.java:166)
	at org.jboss.as.test.shared.observability.containers.OpenTelemetryCollectorContainer.assertMetrics(OpenTelemetryCollectorContainer.java:149)
	at org.wildfly.test.integration.observability.opentelemetry.OpenTelemetryMetricsTestCase.getMetrics(OpenTelemetryMetricsTestCase.java:68)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
------- Stderr: -------
[Jaeger] Query port: 33678
[Jaeger] OTLP port: 33677
[Jaeger] port bindings: []
[OpenTelemetryCollector] OTLP gRPC port: 33674
[OpenTelemetryCollector] OTLP HTTP port: 33675
[OpenTelemetryCollector] Prometheus port: 33673
[OpenTelemetryCollector] port bindings: []
[Jaeger] Query port: 33678
[Jaeger] OTLP port: 33677
[Jaeger] port bindings: []
[OpenTelemetryCollector] OTLP gRPC port: 33674
[OpenTelemetryCollector] OTLP HTTP port: 33675
[OpenTelemetryCollector] Prometheus port: 33673
[OpenTelemetryCollector] port bindings: []
[OpenTelemetryCollector] assertMetrics(..) validation starting.
[OpenTelemetryCollector] assertMetrics(..) validation failed - retrying.
[OpenTelemetryCollector] 2025-01-21T23:38:13.734Z	info	Traces	{"kind": "exporter", "data_type": "traces", "name": "debug", "resource spans": 2, "spans": 2}

[OpenTelemetryCollector] 2025-01-21T23:38:13.734Z	info	ResourceSpans #0

[OpenTelemetryCollector] Resource SchemaURL: 

[OpenTelemetryCollector] Resource attributes:

[OpenTelemetryCollector]      -> service.name: Str(otel-metrics-test.war)

[OpenTelemetryCollector]      -> telemetry.sdk.language: Str(java)

[OpenTelemetryCollector]      -> telemetry.sdk.name: Str(opentelemetry)

[OpenTelemetryCollector]      -> telemetry.sdk.version: Str(1.42.1)

@bstansberry
Copy link
Contributor Author

The failure seems like it might be related.

@jamezp This PR only touches host controller code and none of the failures are in tests running a domain; they are use standalone servers. They all fail intermittently.

@bstansberry bstansberry added the hold Do not merge this PR label Jan 22, 2025
@bstansberry
Copy link
Contributor Author

I put the 'hold' label on this as I just realized the existing HostControllerBootstrap doesn't have a try/catch block in bootstrap. That's only in EmbeddedHostControllerBootstrap. So I'll need to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luck3y luck3y luck3y approved these changes

Assignees
No one assigned
Labels
hold Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bstansberry @jamezp @wildfly-ci @luck3y