Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass non-zero msg.value directly to proxy constructor #21

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Allow to pass non-zero msg.value directly to proxy constructor #21

merged 2 commits into from
Jan 17, 2024

Conversation

k06a
Copy link
Contributor

@k06a k06a commented Jan 17, 2024 •
edited
Loading

Passing some value before proxy creation requires proxy address extra computation, transfering value after creation triggers both proxy and implementation calls.

I see create3 proxy contract already supports msg.value:

CALLDATASIZE
RETURNDATASIZE
RETURNDATASIZE
CALLDATACOPY
CALLDATASIZE
RETURNDATASIZE
CALLVALUE
CREATE

@wighawag
Copy link
Owner

Hey that sounds good. to me

I had to merge another PR first, could you update the PR for conflict, Thanks!

@k06a k06a force-pushed the feature/msg-value branch from 86cbdc1 to b7e9b82 Compare January 17, 2024 13:48
@k06a
Copy link
Contributor Author

k06a commented Jan 17, 2024

@wighawag rebased

@k06a
Copy link
Contributor Author

k06a commented Jan 17, 2024

Added some tests

@wighawag wighawag merged commit bf8cb7d into wighawag:master Jan 17, 2024
1 check passed
@wighawag
Copy link
Owner

Thanks @k06a for the PR and adding the tests!

@k06a k06a deleted the feature/msg-value branch January 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k06a @wighawag