Editorial: improve fragment parsing #10874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the argument order consistent and corrects a false statement about what the XML fragment parser returns. It also generally improves alignment with Infra and other best practices, though it does not improve the actual integration with the parsers.
sideshowbarker
approved these changes
Dec 31, 2024
Comment on lines
+134277
to
+134279
| <p>The <dfn>HTML fragment parsing algorithm</dfn> given an <code>Element</code> node <dfn | ||
| data-x="concept-frag-parse-context"><var>context</var></dfn>, string <var>input</var>, and an | ||
| optional boolean <var>allowDeclarativeShadowRoots</var> (default false) are the following steps. |
There was a problem hiding this comment.
Suggested change
| <p>The <dfn>HTML fragment parsing algorithm</dfn> given an <code>Element</code> node <dfn | |
| data-x="concept-frag-parse-context"><var>context</var></dfn>, string <var>input</var>, and an | |
| optional boolean <var>allowDeclarativeShadowRoots</var> (default false) are the following steps. | |
| <p>The <dfn>HTML fragment parsing algorithm</dfn>, given an <code>Element</code> node <dfn | |
| data-x="concept-frag-parse-context"><var>context</var></dfn>, string <var>input</var>, and an | |
| optional boolean <var>allowDeclarativeShadowRoots</var> (default false) is the following steps. |
Comment on lines
+134365
to
+134367
| <p>Let this start tag token be the start tag token of <var | ||
| data-x="concept-frag-parse-context">context</var>, e.g. for the purposes of determining if it is | ||
| an <span>HTML integration point</span>.</p> |
There was a problem hiding this comment.
Suggested change
| <p>Let this start tag token be the start tag token of <var | |
| data-x="concept-frag-parse-context">context</var>, e.g. for the purposes of determining if it is | |
| an <span>HTML integration point</span>.</p> | |
| <p>Let this start tag token be the start tag token of <var | |
| data-x="concept-frag-parse-context">context</var>; e.g. for the purposes of determining if it is | |
| an <span>HTML integration point</span>.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the argument order consistent and corrects a false statement about what the XML fragment parser returns. It also generally improves alignment with Infra and other best practices, though it does not improve the actual integration with the parsers.
Noticed this while working on scoped custom element registries.
/dynamic-markup-insertion.html ( diff )
/parsing.html ( diff )
/xhtml.html ( diff )