-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/GitHub actions #10
Conversation
4e41fd8
to
f8af5d4
Compare
4e0ae77
to
421e7b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning for maintaining different products (themes) in this repo?
I would have thought that is best implemented within each individual product, as it seems to add a lot of (in my opinion, unnecessary) complexity to the design system...
I agree that handling themes (products) adds more complexity to the codebase. But, I thought it would be a good idea to provide all the core and semantic tokens available for each team. Each team would then handle the component-level tokens. We should definitely have a chat about that. I'll send a message in the Slack channel today. |
This PR
The flow is as follows:
tokens.json
file is updated.tokens.json
file is split into smaller files based on the keys.$themes.json
file is added by the developer and will need to be updated if any new products are added to Tokens Studio.Since we are on a free plan, we have to simulate "theming". If we were on a paid version, the tokens.json would have $themes values sent to us from Figma. But, since we don't have that, we need to create it. This PR does't handle the mobile, tablet, and desktop JSON files yet.
core, semantic, and all of the products.
FIle structure explained:
tokens.json
: our main file used to store and send tokens between GitHub and Figma.tokens
: a folder where we store tokens from Figma, but we have split them into smaller JSON files by runningnpm run split-json
.tokens/$themes.json
: the only file not generated from tokens.json. It is added by the developer and simulates Figma theming.generatedTokens
: a folder to store all the variables generated by Style Dictionary.