Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #417 missing module chunks #433

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Fixes #417 missing module chunks #433

merged 4 commits into from
Apr 13, 2021

Conversation

deanshub
Copy link
Contributor

@deanshub deanshub commented Apr 11, 2021 •
edited by valscion
Loading

Fixes #417 missing module chunks

@valscion
Copy link
Member

Hello, and thank you for your contribution!

The code does look good to me. However, I'm a bit worried about our CI failing, likely not due to something you've done but something that is out of our control right now.

I'm copy-pasting from my comment in another PR (this one: #432 (comment)):

I haven't had the time to look into why the tests are timing out or getting aborted. Any help in getting the GitHub actions to run properly would be very much appreciated and would also help reviewing this PR once we're happy with the way the feature has been designed 🙏

We haven't really done anything about the CI since #402 where the checks were running successfully. So something has likely changed since then, and it likely isn't anything we've written as there isn't quite much git history since removing Travis CI: https://github.com/webpack-contrib/webpack-bundle-analyzer/commits/master

Any help in fixing our CI would be highly appreciated! 🙏

@deanshub deanshub mentioned this pull request Apr 13, 2021
Merged
@deanshub deanshub force-pushed the missing-module-chunks-bugfix branch from 7a404b6 to a705b1b Compare April 13, 2021 08:08
valscion
valscion approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me!

@valscion valscion merged commit e5b617e into webpack-contrib:master Apr 13, 2021
@deanshub deanshub deleted the missing-module-chunks-bugfix branch April 13, 2021 08:15
@valscion
Copy link
Member

Released in v4.4.1, thank you for your contributions ☺️

@valscion valscion mentioned this pull request Apr 13, 2021
Closed
deanshub added a commit to wix-incubator/webpack-bundle-analyzer that referenced this pull request Aug 19, 2021
@shlior7 @deanshub
@valscion @dependabot @kedarv @th0r
npm publish and upstream fetch (#2)
d531e2a 
* Fix tests timeout (webpack-contrib#435)

* Fix tests timeout

* wip

* increasing timeout

* Update test/plugin.js

Co-authored-by: Vesa Laakso <[email protected]>

* increasing timeout

Co-authored-by: Vesa Laakso <[email protected]>

* Fixes webpack-contrib#417 missing module chunks (webpack-contrib#433)

* Fixes webpack-contrib#417 missing module chunks

* triger build

* test fix

* test fix

* Fix changelog username link texts

* v4.4.1

* Bump url-parse from 1.4.7 to 1.5.1 (webpack-contrib#443)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.1.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.4.7...1.5.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump postcss from 8.1.6 to 8.2.10 (webpack-contrib#446)

Bumps [postcss](https://github.com/postcss/postcss) from 8.1.6 to 8.2.10.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.1.6...8.2.10)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* check this.compiler.outputFileSystem.constructor is not undefined (webpack-contrib#447)

* check this.compiler.outputFileSystem.constructor is not undefined

* Fix trailing spaces lint

* Update changelog with bug fix

Co-authored-by: Vesa Laakso <[email protected]>

* v4.4.2

* Update deps

* Remove unused `exports-loader`

* Bump hosted-git-info from 2.8.8 to 2.8.9 (webpack-contrib#445)

Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](npm/hosted-git-info@v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump browserslist from 4.14.6 to 4.16.6 in /test/webpack-versions/5.4.0 (webpack-contrib#450)

Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.14.6 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](browserslist/browserslist@4.14.6...4.16.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump dns-packet from 1.3.1 to 1.3.4 (webpack-contrib#451)

Bumps [dns-packet](https://github.com/mafintosh/dns-packet) from 1.3.1 to 1.3.4.
- [Release notes](https://github.com/mafintosh/dns-packet/releases)
- [Changelog](https://github.com/mafintosh/dns-packet/blob/master/CHANGELOG.md)
- [Commits](mafintosh/dns-packet@v1.3.1...v1.3.4)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ws from 7.4.5 to 7.4.6 (webpack-contrib#452)

Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.4.6.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@7.4.5...7.4.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump normalize-url from 4.5.0 to 4.5.1 (webpack-contrib#455)

Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/sindresorhus/normalize-url/releases)
- [Commits](https://github.com/sindresorhus/normalize-url/commits)

---
updated-dependencies:
- dependency-name: normalize-url
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ssri from 6.0.1 to 6.0.2 in /test/webpack-versions/4.44.2 (webpack-contrib#441)

Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/npm/ssri/releases)
- [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md)
- [Commits](npm/ssri@v6.0.1...v6.0.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump elliptic from 6.5.3 to 6.5.4 in /test/webpack-versions/4.44.2 (webpack-contrib#421)

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* npm publish

* npm publish

* lint fix

* npmpublic

* name-change

* test title change

* yarnrc

* fixed yarnrc

Co-authored-by: Dean Shub <[email protected]>
Co-authored-by: Vesa Laakso <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kedar <[email protected]>
Co-authored-by: th0r <[email protected]>
@moul-bot moul-bot mentioned this pull request Oct 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valscion valscion valscion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stats parsing is broken when using "all: true" and Webpack 5
2 participants
@deanshub @valscion