Extract Safari version from safaridriver

[foolip]

No description provided.

[foolip]

This sort of works but is only half done. Sent out with comments hoping that @jgraham or @jugglinmike might have ideas. For what's left a mystery I will dig in myself :)

[foolip]

I've found that call doesn't suppress stderr and just prints it instead. This isn't great because this is expected to fail on every safaridriver before STP 67, notable including Safari 12 stable. Should I just change call to return a stdout,stderr tuple?

[jgraham]

That's surprising; it looks like it calls subprocess.checkou_output with no arguments. I would suggest making it take **kwargs and passing those down to the caller so you can redirect stderr to /dev/null or whatever.

[foolip]

I don't know why this, is the logger not wired up correctly?

[jgraham]

I think the logger handler gets wired up late, but we should probably fix that.

[foolip]

Needs to be rebased on top of #13642 now.

[Hexcles]

@foolip could your rebase this and fix the unit tests?

[foolip]

Alright, this finally works! A snippet from a wpt_report.json produced locally:

    "run_info": {
        "bits": 64,
        "browser_channel": "preview",
        "browser_version": "Technology Preview (Release 68, 13607.1.11)",
        "debug": false,
        "has_sandbox": true,
        "os": "mac",
        "os_version": "10.13",
        "processor": "x86_64",
        "product": "safari_webdriver",
        "revision": "eb59233bf287cd7391926719bcfc9bf9f4e02a20",
        "verify": false,
        "version": "OS X 10.13.6",
        "wasm": false
    }

(It works when using --webdriver-binary instead of --channel too, but then "browser_channel" won't be present. That's why it's a good idea to include "Technology Preview" in the output.)