-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make ::scroll-button disabled state snap aware
Scroll buttons should be disabled when snapping prevents any further scrolling in their intended direction. Bug: 388545125 Change-Id: I5991f2ff02965a2495a7507d74504b3f213f2657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6180126 Reviewed-by: Vladimir Levin <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Commit-Queue: Robert Flack <[email protected]> Cr-Commit-Position: refs/heads/main@{#1409802}
- Loading branch information
1 parent
ecd260d
commit 23bf1d4
Showing
2 changed files
with
167 additions
and
0 deletions.
There are no files selected for viewing
82 changes: 82 additions & 0 deletions
82
css/css-overflow/scroll-buttons-disabled-snapping-ref.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| <!doctype html> | ||
| <title>CSS Test: ::scroll-button(*) :disabled triggers when snapping prevents further scrolling</title> | ||
| <link rel="help" href="https://drafts.csswg.org/css-overflow-5/#scroll-buttons"> | ||
| <style> | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .scroller { | ||
| width: 50px; | ||
| height: 50px; | ||
| overflow: hidden; | ||
| margin: 20px; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .horizontal { | ||
| white-space: nowrap; | ||
| scroll-snap-type: x mandatory; | ||
| padding: 0 20px; | ||
| } | ||
| .vertical { | ||
| white-space: nowrap; | ||
| scroll-snap-type: y mandatory; | ||
| padding: 20px 0; | ||
| } | ||
|
|
||
| .scroller div { | ||
| background: lightblue; | ||
| border: 2px solid blue; | ||
| width: 50px; | ||
| height: 50px; | ||
| box-sizing: border-box; | ||
| scroll-snap-align: center; | ||
| } | ||
|
|
||
| .scroller.horizontal div { | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .scroll-button { | ||
| background: green; | ||
| border: 1px solid black; | ||
| display: inline-block; | ||
| height: 20px; | ||
| width: 20px; | ||
| color: white; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .scroll-button.disabled { | ||
| background: gray; | ||
| } | ||
|
|
||
|
|
||
| </style> | ||
| <div class="horizontal scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div><div class="scroll-button inline-start disabled"></div><div class="scroll-button inline-end"></div></div> | ||
| <div class="horizontal scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div><div class="scroll-button inline-start"></div><div class="scroll-button inline-end disabled"></div></div> | ||
| <div class="vertical scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div><div class="scroll-button block-start disabled"></div><div class="scroll-button block-end"></div></div> | ||
| <div class="vertical scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div><div class="scroll-button block-start"></div><div class="scroll-button block-end disabled"></div></div> | ||
| <script> | ||
| const scrollers = document.querySelectorAll('.scroller'); | ||
| scrollers[1].scrollLeft = 1000; | ||
| scrollers[3].scrollTop = 1000; | ||
| </script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| <!doctype html> | ||
| <title>CSS Test: ::scroll-button(inline-end) supports :disabled</title> | ||
| <link rel="help" href="https://drafts.csswg.org/css-overflow-5/#scroll-buttons"> | ||
| <link rel="match" href="scroll-buttons-disabled-snapping-ref.html"> | ||
| <style> | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .scroller { | ||
| width: 50px; | ||
| height: 50px; | ||
| overflow: hidden; | ||
| margin: 20px; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .horizontal { | ||
| white-space: nowrap; | ||
| scroll-snap-type: x mandatory; | ||
| padding: 0 20px; | ||
| } | ||
| .vertical { | ||
| white-space: nowrap; | ||
| scroll-snap-type: y mandatory; | ||
| padding: 20px 0; | ||
| } | ||
|
|
||
| .scroller div { | ||
| background: lightblue; | ||
| border: 2px solid blue; | ||
| width: 50px; | ||
| height: 50px; | ||
| box-sizing: border-box; | ||
| scroll-snap-align: center; | ||
| } | ||
|
|
||
| .scroller.horizontal div { | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .scroller::scroll-button(*) { | ||
| box-sizing: border-box; | ||
| background: green; | ||
| border: 1px solid black; | ||
| display: inline-block; | ||
| height: 20px; | ||
| width: 20px; | ||
| color: white; | ||
| } | ||
|
|
||
| .scroller::scroll-button(*):disabled { | ||
| background: gray; | ||
| } | ||
|
|
||
| .scroller.vertical::scroll-button(block-start), | ||
| .scroller.vertical::scroll-button(block-end), | ||
| .scroller.horizontal::scroll-button(inline-start), | ||
| .scroller.horizontal::scroll-button(inline-end) { | ||
| content: " "; | ||
| } | ||
|
|
||
| </style> | ||
| <div class="horizontal scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div class="horizontal scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div class="vertical scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <div class="vertical scroller"> | ||
| <div></div> | ||
| <div></div> | ||
| </div> | ||
| <script> | ||
| const scrollers = document.querySelectorAll('.scroller'); | ||
| scrollers[1].scrollLeft = 1000; | ||
| scrollers[3].scrollTop = 1000; | ||
| </script> |