Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clear button #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add clear button #156

wants to merge 1 commit into from

Conversation

nevermoresss
Copy link

No description provided.

@wdullaer
Copy link
Owner

What does this do?
It seems like it adds just ad additional callback method (which btw has a typo in its name).

What does this buy you that you can't accomplish with the standard Dialog callbacks or say a button in your app?

@nevermoresss
Copy link
Author

i think that if someone like me wants to clear a task's duedate than he needs to add a clear button. actually, the button is gone if you don't set the clearListener. waiting for your reply :)

@wdullaer
Copy link
Owner

This is really too specific functionality for a generic date / timepicker.
If you don't feel comfortable maintaining your own changes, you could use a remove button in your app (see google keep for how they do it), or for example do swipe to remove on the reminder entries (which is what I do in an app).

@nevermoresss
Copy link
Author

ok,thanks for your advice

@wdullaer wdullaer mentioned this pull request Mar 16, 2016
@denversc
Copy link

FYI, I just documented a slightly hacky, but elegant and fully functional, way to add a "Clear" button into DatePickerDialog in issue #183

@Anupriya25
Copy link

@denversc can you please tell how to then use ClearableDatePickerDialog to create a dialog.
DatePickerDialog dpd = DatePickerDialog.newInstance(
MainActivity.this,
now.get(Calendar.YEAR),
now.get(Calendar.MONTH),
now.get(Calendar.DAY_OF_MONTH)
);
instead of datepickerdialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants