Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare peer dependency on html-webpack-plugin #91

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

jscheid
Copy link
Collaborator

@jscheid jscheid commented Oct 3, 2018

Closes #90

@jscheid jscheid changed the title Declare peer dependency on html-wepback-plugin Declare peer dependency on html-webpack-plugin Oct 3, 2018
@fbrusatti fbrusatti merged commit dfa74d0 into master Oct 4, 2018
@fbrusatti fbrusatti deleted the hwp-peer-dependency branch October 4, 2018 13:12
@clydin
Copy link

clydin commented Oct 23, 2018

This should be reverted. Causing a peer dependency warning when the html-wepback-plugin is not in use is an error. Peer dependencies are require dependencies and html-wepback-plugin is not required for this plugin to function (the code is designed to specifically account for that fact). There are legitimate use cases where not using the HTML plugin is completely acceptable. Once of which this the Angular CLI, which cannot currently update the version of this plugin due to this PR's change.

@jscheid
Copy link
Collaborator Author

jscheid commented Oct 23, 2018

@clydin could I ask you to comment on #90 instead?

@clydin
Copy link

clydin commented Oct 23, 2018

It’s closed and this PR is the underlying issue. Unfortunately, If this is not addressed we’ll be forced to consider creating an alternative plugin to handle SRI.

@jscheid
Copy link
Collaborator Author

jscheid commented Oct 24, 2018

I think it would be good if we could continue the conversation on #90, especially because the original impetus for the change request appears to be angular/angular-cli#12465 and you seem to be in a good position to comment on that.

Feel free to reopen the issue.

FWIW, I'm generally not opposed to the idea of reverting a change that does more harm than good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants