Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "error: GitHub API: more that one release selected" in create-exe #5320

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Jan 2, 2025

Issue #5281 shows how, when running wasmer create-exe, an error occurs while downloading libwasmer from the latest release. It is due to the support of engines we recently introduced, which at the time did not allow their coexistence with "regular" engines (the sys ones), making separate releases (-wasmi, -wamr, -v8) necessary. We plan, in the short term, to have a release that allows the simultaneous existence of said engines, so the separate release won't be mandatory anymore - we will have to figure out which engines to ship by default and/or a mechanism to install the necessary libraries (e.g. libiwasm, libwee8..) when needed.

In the meantime, this patch fixes the current behaviour by filtering out the -wasmi, -wamr and -v8 releases upon download of libwasmer.

@xdoardo xdoardo requested a review from syrusakbary as a code owner January 2, 2025 10:14
@xdoardo xdoardo linked an issue Jan 2, 2025 that may be closed by this pull request
@xdoardo xdoardo merged commit 88ffb5d into main Jan 2, 2025
72 checks passed
@xdoardo xdoardo deleted the 5281-error-github-api-more-that-one-release-selected branch January 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error: GitHub API: more that one release selected"
2 participants