Use correct set of source expressions in script directives pre-request check #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script directives pre-request check has a part where it talks about the
hash-algorithm
of an arbitrary source expression. That doesn't make sense. But there's already a variable in scope holding just the hash-source subset of source expressions, which isn't used for anything else except a non-emptiness check. Presumably it should be used instead.For IPR I would consider this to be non-substantive.
Preview | Diff