Improve language/examples around test suite API. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatStLouis
requested changes
Oct 17, 2024
TallTed
requested changes
Oct 18, 2024
aljones15
reviewed
Oct 24, 2024
BigBlueHat
commented
Nov 4, 2024
TallTed
reviewed
Nov 4, 2024
BigBlueHat
commented
Nov 7, 2024
Co-authored-by: Patrick St-Louis <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
BigBlueHat
force-pushed
the
api-clarifications
branch
from
126d138 to
842e87a
Compare
TallTed
approved these changes
Nov 14, 2024
|
@PatStLouis GitHub seems to think I didn't satisfy your requested change. Could you re-review this one? Thanks! |
PatStLouis
requested changes
Nov 18, 2024
| "errors": ["invalid proof"] | ||
| "verified": true, | ||
| "results": {}, | ||
| "error": ["invalid proof"] |
There was a problem hiding this comment.
Suggested change
| "error": ["invalid proof"] | |
| "problemDetails": [] |
Comment on lines
256
to
257
| "warnings": ["invalid-uri"], | ||
| "errors": ["invalid proof"] |
There was a problem hiding this comment.
Suggested change
| "warnings": ["invalid-uri"], | |
| "errors": ["invalid proof"] | |
| "problemDetails": [] |
We can do that in the README, but does any of the code handle that yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.