Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote pytest and sphinc from install requires #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaywink
Copy link
Member

@jaywink jaywink commented May 13, 2017

Including these install a lot of dependencies which are not needed for actually using the library. I would like to propose putting them in extras instead so they can easily be installed in a development environment using:

pip install -e .[dev]

This is the difference:

$ pip install -e .
Successfully installed PyLD-0.7.2 activipy

VS

$ pip install -e .[dev]
Successfully installed Jinja2-2.9.6 MarkupSafe-1.0 Pygments-2.2.0 activipy alabaster-0.7.10 babel-2.4.0 docutils-0.13.1 imagesize-0.7.1 py-1.4.33 pytest-3.0.7 pytz-2017.2 requests-2.14.2 snowballstemmer-1.2.1 sphinx-1.5.5

In a production system all those extra packages are not very nice :)

This does however create a problem with the console scripts. Is there a reason the test client needs to be installed via a package?

Including these install a lot of dependencies which are not needed for actually using the library. Put them in extras instead so they can easily be installed in a development environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant