-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: a more intuitive way to configure and override #123
Open
haoqunjiang
wants to merge
16
commits into
main
Choose a base branch
from
feat-more-intuitive-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to avoid conflicts with user-defined rules - to serve as an convention across the official vue eslint configs
haoqunjiang
changed the title
[WORK-IN-PROGRESS] feat: a more intuitive config
[WORK-IN-PROGRESS] feat: a more intuitive way to configure and override
Dec 26, 2024
…e succint config
haoqunjiang
changed the title
[WORK-IN-PROGRESS] feat: a more intuitive way to configure and override
feat: a more intuitive way to configure and override
Dec 26, 2024
The PR is almost finished, and it works great with the upcoming rewrite of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatibility is retained in this PR so there's no breaking changes.
The new
defineConfig
needs to alter the configs passed in to the following layout:TODOs:
defineConfigWithVueTs
is a good enough name;defineConfigWithVueTs
is omitted, the current error message isn't clear.base
automatically if the user forgets to add any ofvueTsConfigs
in the config file?